Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Shading from ShadingType #1368

Closed
jelgerjansen opened this issue Jul 26, 2024 · 2 comments
Closed

Remove Shading from ShadingType #1368

jelgerjansen opened this issue Jul 26, 2024 · 2 comments
Assignees
@jelgerjansen

Comments

@jelgerjansen
Copy link
Contributor

jelgerjansen commented Jul 26, 2024 •
edited
Loading

The Shading model IDEAS.Buildings.Components.Shading.Shading allows users to define a shading type based on a record. The different shading options are listed in IDEAS.Buildings.Components.Shading.Interfaces.ShadingType. However, the latter includes the option Shading, which is of course not a valid option and should be removed.

@Mathadon as you originally developed this model: Could you confirm this?
@Mathadon
Copy link
Member

@jelgerjansen that indeed sounds wrong :)

@jelgerjansen jelgerjansen self-assigned this Jul 29, 2024
@jelgerjansen jelgerjansen mentioned this issue Jul 29, 2024
Merged
@jelgerjansen
Copy link
Contributor Author

Closed by #1370

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jelgerjansen jelgerjansen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Mathadon @jelgerjansen