Skip to content

Commit

Permalink
Remove some more (obsolete) import statements
Browse files Browse the repository at this point in the history
  • Loading branch information
jelgerjansen committed Feb 7, 2025
1 parent b73ab6e commit 8600fca
Show file tree
Hide file tree
Showing 22 changed files with 170 additions and 58 deletions.
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
within IDEAS.BoundaryConditions.Examples;
model StrobeInfoManager_offset
"Unit test for SimInfoManager with time offset on read data"
import IDEAS;
extends Modelica.Icons.Example;
inner IDEAS.BoundaryConditions.Occupants.Extern.StrobeInfoManager strobe(
nOcc=10,
Expand All @@ -26,6 +25,11 @@ model StrobeInfoManager_offset
Documentation(revisions="<html>
<ul>
<li>
February 7, 2025, by Jelger Jansen:<br/>
Removed <code>import IDEAS</code> statement.
See <a href=\"https://github.com/open-ideas/IDEAS/issues/1415\">#1415</a>.
</li>
<li>
December 20, 2017 by Bram van der Heijde:<br/>
First implementation.
</li>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
within IDEAS.Buildings.Components.BaseClasses.RadiativeHeatTransfer.Examples;
model ZoneLwGainDistribution
import IDEAS;
extends Modelica.Icons.Example;
Modelica.Blocks.Sources.Ramp ramDir(
duration=1,
Expand Down Expand Up @@ -90,6 +89,11 @@ equation
Documentation(revisions="<html>
<ul>
<li>
February 7, 2025, by Jelger Jansen:<br/>
Removed <code>import IDEAS</code> statement.
See <a href=\"https://github.com/open-ideas/IDEAS/issues/1415\">#1415</a>.
</li>
<li>
January 19, 2017 by Filip Jorissen:<br/>
First implementation
</li>
Expand Down
11 changes: 9 additions & 2 deletions IDEAS/Controls/Discrete/Examples/HysteresisRelease_Cooling.mo
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
within IDEAS.Controls.Discrete.Examples;
model HysteresisRelease_Cooling
"Example model for hysteresis with variable uLow and uHigh"
import IDEAS;
extends Modelica.Icons.Example;
IDEAS.Controls.Discrete.HysteresisRelease con(revert=false)
annotation (Placement(transformation(extent={{-40,20},{-20,40}})));
Expand Down Expand Up @@ -94,7 +93,15 @@ This example can be simulated with the \"simulate and plot\" command in the Comm
</p>
</html>", revisions="<html>
<ul>
<li>November 2014, Roel De Coninck and Damien Picard</li>
<li>
February 7, 2025, by Jelger Jansen:<br/>
Removed <code>import IDEAS</code> statement.
See <a href=\"https://github.com/open-ideas/IDEAS/issues/1415\">#1415</a>.
</li>
<li>
November, 2014, by Roel De Coninck and Damien Picard:<br/>
First implementation.
</li>
</ul>
</html>"));
end HysteresisRelease_Cooling;
11 changes: 9 additions & 2 deletions IDEAS/Controls/Discrete/Examples/HysteresisRelease_Heating.mo
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
within IDEAS.Controls.Discrete.Examples;
model HysteresisRelease_Heating
"Example model for hysteresis with variable uLow and uHigh"
import IDEAS;
extends Modelica.Icons.Example;
IDEAS.Controls.Discrete.HysteresisRelease con(revert=true)
annotation (Placement(transformation(extent={{-40,20},{-20,40}})));
Expand Down Expand Up @@ -94,7 +93,15 @@ temperature of the capacity between uLow and uHigh. This example can be simulate
</p>
</html>", revisions="<html>
<ul>
<li>November 2014, Roel De Coninck and Damien Picard</li>
<li>
February 7, 2025, by Jelger Jansen:<br/>
Removed <code>import IDEAS</code> statement.
See <a href=\"https://github.com/open-ideas/IDEAS/issues/1415\">#1415</a>.
</li>
<li>
November, 2014, by Roel De Coninck and Damien Picard:<br/>
First implementation.
</li>
</ul>
</html>"));
end HysteresisRelease_Heating;
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ protected
Z) for i in 1:3};
parameter Modelica.Units.SI.Reactance[3,Nodes] X3={Modelica.ComplexMath.imag(
Z) for i in 1:3};
// parameter Modelica.Units.SI.ComplexVoltage[3] Vsource3={Vsource*(cos(c.pi*2*i/3)+MCM.j*sin(c.pi*2*i/6)) for i in 1:3};
// parameter Modelica.Units.SI.ComplexVoltage[3] Vsource3={Vsource*(cos(c.pi*2*i/3)+Modelica.ComplexMath.j*sin(c.pi*2*i/6)) for i in 1:3};

//Absolute voltages at the nodes
output Modelica.Units.SI.Voltage Vabs[3,Nodes];
Expand Down Expand Up @@ -163,11 +163,12 @@ equation
color={85,170,255},
smooth=Smooth.Bezier,
pattern=LinePattern.Dash)}),
Documentation(revisions="<html>
Documentation(revisions="<html>
<ul>
<li>
February 4, 2025, by Jelger Jansen:<br/>
February 7, 2025, by Jelger Jansen:<br/>
Added <code>Modelica.Units.</code> to one or multiple parameter(s) due to the removal of <code>import</code> in IDEAS/package.mo.
Added <code>Modelica.ComplexMath.</code> to one or multiple parameter(s) due to the removal of <code>import</code> in IDEAS/Experimental/Electric/package.mo.
See <a href=\"https://github.com/open-ideas/IDEAS/issues/1415\">#1415</a> .
</li>
</ul>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,12 @@ model MvLvTransformer_1P
"Grid frequency: should normally not be changed when simulating belgian grids!";
parameter Modelica.Units.SI.ComplexVoltage VSource=230 + 0*Modelica.ComplexMath.j
"Voltage" annotation (choices(
choice=(230*1) + 0*MCM.j "100% at HVpin of transformer",
choice=(230*1.02) + 0*MCM.j "102% at HVpin of transformer",
choice=(230*1.05) + 0*MCM.j "105% at HVpin of transformer",
choice=(230*1.1) + 0*MCM.j "110% at HVpin of transformer",
choice=(230*0.95) + 0*MCM.j "95% at HVpin of transformer",
choice=(230*0.9) + 0*MCM.j "90% at HVpin of transformer"));
choice=(230*1) + 0* Modelica.ComplexMath.j "100% at HVpin of transformer",
choice=(230*1.02) + 0* Modelica.ComplexMath.j "102% at HVpin of transformer",
choice=(230*1.05) + 0* Modelica.ComplexMath.j "105% at HVpin of transformer",
choice=(230*1.1) + 0* Modelica.ComplexMath.j "110% at HVpin of transformer",
choice=(230*0.95) + 0* Modelica.ComplexMath.j "95% at HVpin of transformer",
choice=(230*0.9) + 0* Modelica.ComplexMath.j "90% at HVpin of transformer"));

final parameter Modelica.Units.SI.HeatFlowRate traLosQRef=transformer.P0 +
Modelica.ComplexMath.real(transformer.Zd)*(transformer.Sn/3/
Expand Down Expand Up @@ -212,5 +212,14 @@ equation
points={{50,-60},{80,-60},{80,40},{140,40}},
color={85,170,255},
smooth=Smooth.None,
pattern=LinePattern.Dash)}));
pattern=LinePattern.Dash)}),
Documentation(revisions="<html>
<ul>
<li>
February 7, 2025, by Jelger Jansen:<br/>
Added <code>Modelica.ComplexMath.</code> to one or multiple parameter(s) due to the removal of <code>import</code> in IDEAS/Experimental/Electric/package.mo.
See <a href=\"https://github.com/open-ideas/IDEAS/issues/1415\">#1415</a> .
</li>
</ul>
</html>"));
end MvLvTransformer_1P;
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,12 @@ model MvLvTransformer_3P
"Grid frequency: should normally not be changed when simulating belgian grids!";
parameter Modelica.Units.SI.ComplexVoltage VSource=230 + 0*Modelica.ComplexMath.j
"Voltage" annotation (choices(
choice=(230*1) + 0*MCM.j "100% at HVpin of transformer",
choice=(230*1.02) + 0*MCM.j "102% at HVpin of transformer",
choice=(230*1.05) + 0*MCM.j "105% at HVpin of transformer",
choice=(230*1.1) + 0*MCM.j "110% at HVpin of transformer",
choice=(230*0.95) + 0*MCM.j "95% at HVpin of transformer",
choice=(230*0.9) + 0*MCM.j "90% at HVpin of transformer"));
choice=(230*1) + 0* Modelica.ComplexMath.j "100% at HVpin of transformer",
choice=(230*1.02) + 0* Modelica.ComplexMath.j "102% at HVpin of transformer",
choice=(230*1.05) + 0* Modelica.ComplexMath.j "105% at HVpin of transformer",
choice=(230*1.1) + 0* Modelica.ComplexMath.j "110% at HVpin of transformer",
choice=(230*0.95) + 0* Modelica.ComplexMath.j "95% at HVpin of transformer",
choice=(230*0.9) + 0* Modelica.ComplexMath.j "90% at HVpin of transformer"));

final parameter Modelica.Units.SI.HeatFlowRate traLosQRef=transformer.P0 +
Modelica.ComplexMath.real(transformer.Zd)*(transformer.Sn/3/
Expand Down Expand Up @@ -316,5 +316,14 @@ Small changes.
Line(
points={{-60,-2},{-64,-10},{-68,-10},{-74,10}},
color={0,0,0},
smooth=Smooth.None)}));
smooth=Smooth.None)})),
Documentation(revisions="<html>
<ul>
<li>
February 7, 2025, by Jelger Jansen:<br/>
Added <code>Modelica.ComplexMath.</code> to one or multiple parameter(s) due to the removal of <code>import</code> in IDEAS/Experimental/Electric/package.mo.
See <a href=\"https://github.com/open-ideas/IDEAS/issues/1415\">#1415</a> .
</li>
</ul>
</html>"));
end MvLvTransformer_3P;
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
within IDEAS.Experimental.Electric.Distribution.AC.Examples.Components;
model Transformer
import IDEAS;

parameter Modelica.Units.SI.Temperature THsRef=326.6;
parameter Modelica.Units.SI.Temperature TToRef=314.44;
Expand Down Expand Up @@ -36,5 +35,14 @@ equation
color={0,0,127},
smooth=Smooth.None));
annotation (Diagram(coordinateSystem(preserveAspectRatio=false, extent={{-100,
-100},{100,100}}), graphics));
-100},{100,100}}), graphics),
Documentation(revisions="<html>
<ul>
<li>
February 7, 2025, by Jelger Jansen:<br/>
Removed <code>import IDEAS</code> statement.
See <a href=\"https://github.com/open-ideas/IDEAS/issues/1415\">#1415</a>.
</li>
</ul>
</html>"));
end Transformer;
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
within IDEAS.Experimental.Electric.Distribution.AC.Examples;
model TestGridGeneral1PEq
import IDEAS;
extends Modelica.Icons.Example;
extends Modelica.Icons.Example;
IDEAS.Experimental.Electric.Distribution.AC.Examples.Components.SinePower
risingflankSingle1(amplitude=12000)
annotation (Placement(transformation(extent={{40,0},{60,20}})));
Expand All @@ -27,6 +26,11 @@ equation
graphics), Documentation(revisions="<html>
<ul>
<li>
February 7, 2025, by Jelger Jansen:<br/>
Removed <code>import IDEAS</code> statement.
See <a href=\"https://github.com/open-ideas/IDEAS/issues/1415\">#1415</a>.
</li>
<li>
May 22, 2022, by Filip Jorissen:<br/>
Removed experiment annotation to avoid failing OMC tests.
See <a href=\"https://github.com/open-ideas/IDEAS/issues/1254\">
Expand Down
23 changes: 16 additions & 7 deletions IDEAS/Experimental/Electric/Distribution/AC/Grid_1PEq.mo
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,12 @@ public

parameter Modelica.Units.SI.ComplexVoltage VSource=230 + 0*Modelica.ComplexMath.j
"Voltage" annotation (choices(
choice=(230*1) + 0*MCM.j "100% at HVpin of transformer",
choice=(230*1.02) + 0*MCM.j "102% at HVpin of transformer",
choice=(230*1.05) + 0*MCM.j "105% at HVpin of transformer",
choice=(230*1.1) + 0*MCM.j "110% at HVpin of transformer",
choice=(230*0.95) + 0*MCM.j "95% at HVpin of transformer",
choice=(230*0.9) + 0*MCM.j "90% at HVpin of transformer"));
choice=(230*1) + 0* Modelica.ComplexMath.j "100% at HVpin of transformer",
choice=(230*1.02) + 0* Modelica.ComplexMath.j "102% at HVpin of transformer",
choice=(230*1.05) + 0* Modelica.ComplexMath.j "105% at HVpin of transformer",
choice=(230*1.1) + 0* Modelica.ComplexMath.j "110% at HVpin of transformer",
choice=(230*0.95) + 0* Modelica.ComplexMath.j "95% at HVpin of transformer",
choice=(230*0.9) + 0* Modelica.ComplexMath.j "90% at HVpin of transformer"));

Components.MvLvTransformer_1P transformer_MvLv(transformer=transformer, traTCal=
traTCal)
Expand Down Expand Up @@ -108,5 +108,14 @@ equation
Line(
points={{-100,-60},{-42,20},{0,44}},
color={85,170,255},
smooth=Smooth.Bezier)}));
smooth=Smooth.Bezier)})),
Documentation(revisions="<html>
<ul>
<li>
February 7, 2025, by Jelger Jansen:<br/>
Added <code>Modelica.ComplexMath.</code> to one or multiple parameter(s) due to the removal of <code>import</code> in IDEAS/Experimental/Electric/package.mo.
See <a href=\"https://github.com/open-ideas/IDEAS/issues/1415\">#1415</a> .
</li>
</ul>
</html>"));
end Grid_1PEq;
23 changes: 16 additions & 7 deletions IDEAS/Experimental/Electric/Distribution/AC/Grid_3P.mo
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,12 @@ public

parameter Modelica.Units.SI.ComplexVoltage VSource=230 + 0*Modelica.ComplexMath.j
"Voltage" annotation (choices(
choice=(230*1) + 0*MCM.j "100% at HVpin of transformer",
choice=(230*1.02) + 0*MCM.j "102% at HVpin of transformer",
choice=(230*1.05) + 0*MCM.j "105% at HVpin of transformer",
choice=(230*1.1) + 0*MCM.j "110% at HVpin of transformer",
choice=(230*0.95) + 0*MCM.j "95% at HVpin of transformer",
choice=(230*0.9) + 0*MCM.j "90% at HVpin of transformer"));
choice=(230*1) + 0* Modelica.ComplexMath.j "100% at HVpin of transformer",
choice=(230*1.02) + 0* Modelica.ComplexMath.j "102% at HVpin of transformer",
choice=(230*1.05) + 0* Modelica.ComplexMath.j "105% at HVpin of transformer",
choice=(230*1.1) + 0* Modelica.ComplexMath.j "110% at HVpin of transformer",
choice=(230*0.95) + 0* Modelica.ComplexMath.j "95% at HVpin of transformer",
choice=(230*0.9) + 0* Modelica.ComplexMath.j "90% at HVpin of transformer"));

/***Everything related to the transfomer***/
Components.MvLvTransformer_3P transformer_MvLv(transformer=transformer, traTCal=
Expand Down Expand Up @@ -129,5 +129,14 @@ equation
Line(
points={{-100,60},{-42,12},{0,36}},
color={0,0,0},
smooth=Smooth.Bezier)}));
smooth=Smooth.Bezier)})),
Documentation(revisions="<html>
<ul>
<li>
February 7, 2025, by Jelger Jansen:<br/>
Added <code>Modelica.ComplexMath.</code> to one or multiple parameter(s) due to the removal of <code>import</code> in IDEAS/Experimental/Electric/package.mo.
See <a href=\"https://github.com/open-ideas/IDEAS/issues/1415\">#1415</a> .
</li>
</ul>
</html>"));
end Grid_3P;
12 changes: 10 additions & 2 deletions IDEAS/Experimental/Electric/Distribution/DC/Examples/TestGridDC.mo
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
within IDEAS.Experimental.Electric.Distribution.DC.Examples;
model TestGridDC
import IDEAS;
extends Modelica.Icons.Example;
IDEAS.Experimental.Electric.Distribution.DC.GridDCGeneral gridGeneralDC(
redeclare
Expand Down Expand Up @@ -33,5 +32,14 @@ equation
color={0,0,255},
smooth=Smooth.None));
annotation (Diagram(coordinateSystem(preserveAspectRatio=false, extent={{-100,
-100},{100,100}})));
-100},{100,100}})),
Documentation(revisions="<html>
<ul>
<li>
February 7, 2025, by Jelger Jansen:<br/>
Removed <code>import IDEAS</code> statement.
See <a href=\"https://github.com/open-ideas/IDEAS/issues/1415\">#1415</a>.
</li>
</ul>
</html>"));
end TestGridDC;
12 changes: 10 additions & 2 deletions IDEAS/Experimental/Electric/Distribution/DC/GridDCGeneral.mo
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
within IDEAS.Experimental.Electric.Distribution.DC;
model GridDCGeneral
import IDEAS;

replaceable parameter Data.Interfaces.DirectCurrent.GridType grid
"Choose a grid Layout" annotation (choicesAllMatching=true);
Expand Down Expand Up @@ -92,5 +91,14 @@ annotation(Icon(graphics={
points={{48,20},{48,0},{96,0}},
color={0,0,255},
smooth=Smooth.None)}), Diagram(
graphics));
graphics),
Documentation(revisions="<html>
<ul>
<li>
February 7, 2025, by Jelger Jansen:<br/>
Removed <code>import IDEAS</code> statement.
See <a href=\"https://github.com/open-ideas/IDEAS/issues/1415\">#1415</a>.
</li>
</ul>
</html>"));
end GridDCGeneral;
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
within IDEAS.Experimental.Electric.Distribution.Examples.Components;
model Transformer
import IDEAS;

parameter Modelica.Units.SI.Temperature THsRef=326.6;
parameter Modelica.Units.SI.Temperature TToRef=314.44;
Expand Down Expand Up @@ -36,5 +35,14 @@ equation
color={0,0,127},
smooth=Smooth.None));
annotation (Diagram(coordinateSystem(preserveAspectRatio=false, extent={{-100,
-100},{100,100}}), graphics));
-100},{100,100}}), graphics),
Documentation(revisions="<html>
<ul>
<li>
February 7, 2025, by Jelger Jansen:<br/>
Removed <code>import IDEAS</code> statement.
See <a href=\"https://github.com/open-ideas/IDEAS/issues/1415\">#1415</a>.
</li>
</ul>
</html>"));
end Transformer;
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ extends Modelica.Icons.Example;
Photovoltaics.PvSystemGeneralFromFile pVFromFilePQ(numPha=3, PNom=5000)
annotation (Placement(transformation(extent={{-60,60},{-40,80}})));
IDEAS.Experimental.Electric.Distribution.AC.Grid_3P gridGeneral(
VSource=(230*1.02) + 0*MCM.j,
VSource=(230*1.02) + 0*Modelica.ComplexMath.j,
redeclare Data.Grids.Ieee34_AL120 grid,
redeclare Data.TransformerImp.Transfo_100kVA transformer,
traTCal=true)
Expand All @@ -23,6 +23,11 @@ equation
annotation (Documentation(revisions="<html>
<ul>
<li>
February 7, 2025, by Jelger Jansen:<br/>
Added <code>Modelica.ComplexMath.</code> to one or multiple parameter(s) due to the removal of <code>import</code> in IDEAS/Experimental/Electric/package.mo.
See <a href=\"https://github.com/open-ideas/IDEAS/issues/1415\">#1415</a> .
</li>
<li>
May 22, 2022, by Filip Jorissen:<br/>
Removed experiment annotation to avoid failing OMC tests.
See <a href=\"https://github.com/open-ideas/IDEAS/issues/1254\">
Expand Down
Loading

0 comments on commit 8600fca

Please sign in to comment.