Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Per PR 331, templatize config files, use env var & makefile to generate #382

Open
joewxboy opened this issue Aug 6, 2020 · 6 comments
Open
Assignees

Comments

@joewxboy
Copy link
Member

joewxboy commented Aug 6, 2020

Is there an issue open for this TODO?

Originally posted by @dabooz in #331

There is now!

In each of the three services (volantmq, fft_server, fft_client) there are configuration files in the horizon folder that require manual editing per the INSTALL.md instructions.

Please create templates for those files so that they do not need to be modified by hand. Then use the Makefiles to perform an envsubst on the templates to auto-generate the files. This will require the creation and use of a few new environment variables, but some already exist that can be used here.

Once this change is made, please update the INSTALL.md documentation accordingly to remove the sections about manually editing the config files, and instead add a section about pre-populating the environment variables.

@dcmartin
Copy link
Contributor

dcmartin commented Sep 1, 2020

Example standard (de facto) variables : https://github.com/dcmartin/open-horizon/blob/master/docs/MAKEVARS.md

@rajpratyush
Copy link

@joewxboy I would like to take this issue

@joewxboy
Copy link
Member Author

joewxboy commented Mar 3, 2021

@rajpratyush Let me know if you have any questions.

@rajpratyush
Copy link

rajpratyush commented Mar 3, 2021

@joewxboy Cannot find these volantmq, fft_server, fft_client folders in the services is it on a different branch?

@joewxboy
Copy link
Member Author

joewxboy commented Mar 3, 2021

@rajpratyush It looks like the PR has not yet been merged. I'll see if David Booz and Troy Fine will approve merging it.

@rajpratyush
Copy link

@joewxboy ok sir

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants