Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull request previews #102

Open
scottrigby opened this issue Nov 30, 2022 · 1 comment · May be fixed by #106
Open

Pull request previews #102

scottrigby opened this issue Nov 30, 2022 · 1 comment · May be fixed by #106
Labels
enhancement New feature or request

Comments

@scottrigby
Copy link
Member

PS, this was noted way back in #27, which I closed because our immediate deploy automation was working. We don't use Netlify for the site but would love deploy previews on pull requests however we do it. May be good to check out https://github.com/marketplace/actions/deploy-pr-preview
@scottrigby scottrigby added the enhancement New feature or request label Nov 30, 2022
@niklasmtj
Copy link
Member

This is a cool idea. I was checking out the action you mentioned which seems to be easy to integrate. I'm right now testing it but also found the action made available by GitHub: Deploy GitHub pages site which could also be an idea to use.

I think for the forseeable future we should be fine with your proposed action but we can keep an eye on GitHub's action as well.

niklasmtj added a commit that referenced this issue Dec 6, 2022
@niklasmtj
feature: Add action to deploy previews on PR
c35bc06 
This will enable the function of preview deployments
when a PR is open and removes them when the PR is
closed.

Should close #102

Signed-off-by: Niklas Metje <[email protected]>
@niklasmtj niklasmtj linked a pull request Dec 6, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feature: Add action to deploy previews on PR open-gitops/website
2 participants
@scottrigby @niklasmtj