New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feedback 3.0.0-apha #4969

Closed

4 tasks done

joeribekker opened this issue Dec 23, 2024 · 1 comment · Fixed by #4979, #4982 or #4983

Closed

4 tasks done

Feedback 3.0.0-apha #4969

joeribekker opened this issue Dec 23, 2024 · 1 comment · Fixed by #4979, #4982 or #4983

Assignees

Milestone

Contributor

joeribekker commented Dec 23, 2024 •

edited by sergei-maertens

Loading

Needs fixing

Introductie-pagina is verwarrend met toelichtingssjabloon: Vervang de naam "Introductie-pagina" met "Optionele introductie-pagina"
Formulier stap configuratie velden springen over het scherm.
the default_map_tile_layers_json fixture is not loaded (and doesn't use natural keys)
Submission limits seem to reset when saving the form

To discuss

~~Objects API prefill -> the retrieved object is not actually saved in a variable, only the derived properties~~ keep it as it is

The text was updated successfully, but these errors were encountered:

sergei-maertens added this to the Release 3.0 milestone

sergei-maertens added the triage label

sergei-maertens added a commit that referenced this issue


          👽 [#4969] Got bootstrap'ed again

37253fe

Bootstrap CSS hides the django collapsed fieldsets because no .show
class is present. The easiest workaround is to add this class name to
ignore bootstrap's behaviour.

sergei-maertens added a commit that referenced this issue


          🚸 [#4969] Improve form tab UX - introduction page vs explanation

f290bb1

Separate the fields for the introduction page content and the form
explanation content on the start page.

The introduction page is optional, and that's highlighted by putting it
in a collapsed fieldset, separated from the explanation template on
the start page.

sergei-maertens added a commit that referenced this issue


          🚸 [#4969] Organize configuration fields on base tab in fieldsets

4133f36

In an attempt to declutter, related fields are now grouped in fieldsets
and especially fields that are optional are collapsed by default.

The fieldsets report a status where relevant to get a quick overview,
e.g. showing that no auth is configured or that the form is indeed
currently active (without being in maintenance mode).

sergei-maertens mentioned this issue

Layout fixes / declutter the configuration options #4979

Merged

10 tasks

sergei-maertens self-assigned this

sergei-maertens added this to Development

github-project-automation bot moved this to Todo in Development

sergei-maertens moved this from Todo to In Progress in Development

sergei-maertens added a commit that referenced this issue


          🚸 [#4969] Organize configuration fields on base tab in fieldsets

b8e1060

In an attempt to declutter, related fields are now grouped in fieldsets
and especially fields that are optional are collapsed by default.

The fieldsets report a status where relevant to get a quick overview,
e.g. showing that no auth is configured or that the form is indeed
currently active (without being in maintenance mode).

sergei-maertens added a commit that referenced this issue


          ✅ [#4969] Add story for steps tab

8e02004

sergei-maertens added a commit that referenced this issue


          🚸 [#4969] Collapse form definition settings to declutter

9488e5a

If a name and slug (required fields) are provided, the fieldset is
collapsed.

sergei-maertens added a commit that referenced this issue


          ✅ [#4969] Add story to ensure fieldset is expanded if there are errors

870ec45

sergei-maertens added a commit that referenced this issue


          👽 [#4969] Got bootstrap'ed again

8a0e7c2

Bootstrap CSS hides the django collapsed fieldsets because no .show
class is present. The easiest workaround is to add this class name to
ignore bootstrap's behaviour.

sergei-maertens added a commit that referenced this issue


          🚸 [#4969] Improve form tab UX - introduction page vs explanation

172babf

Separate the fields for the introduction page content and the form
explanation content on the start page.

The introduction page is optional, and that's highlighted by putting it
in a collapsed fieldset, separated from the explanation template on
the start page.

sergei-maertens added a commit that referenced this issue


          🚸 [#4969] Organize configuration fields on base tab in fieldsets

8bcdd9a

In an attempt to declutter, related fields are now grouped in fieldsets
and especially fields that are optional are collapsed by default.

The fieldsets report a status where relevant to get a quick overview,
e.g. showing that no auth is configured or that the form is indeed
currently active (without being in maintenance mode).

sergei-maertens added a commit that referenced this issue


          ✅ [#4969] Add story for steps tab

2389f7e

sergei-maertens added a commit that referenced this issue


          🚸 [#4969] Collapse form definition settings to declutter

ddc6e97

If a name and slug (required fields) are provided, the fieldset is
collapsed.

sergei-maertens added a commit that referenced this issue


          ✅ [#4969] Add story to ensure fieldset is expanded if there are errors

3e30737

sergei-maertens added a commit that referenced this issue


          👽 [#4969] Got bootstrap'ed again

4ff03b4

Bootstrap CSS hides the django collapsed fieldsets because no .show
class is present. The easiest workaround is to add this class name to
ignore bootstrap's behaviour.

sergei-maertens added a commit that referenced this issue


          🚸 [#4969] Improve form tab UX - introduction page vs explanation

a29de95

Separate the fields for the introduction page content and the form
explanation content on the start page.

The introduction page is optional, and that's highlighted by putting it
in a collapsed fieldset, separated from the explanation template on
the start page.

sergei-maertens added a commit that referenced this issue


          🚸 [#4969] Organize configuration fields on base tab in fieldsets

442a63e

In an attempt to declutter, related fields are now grouped in fieldsets
and especially fields that are optional are collapsed by default.

The fieldsets report a status where relevant to get a quick overview,
e.g. showing that no auth is configured or that the form is indeed
currently active (without being in maintenance mode).

sergei-maertens added a commit that referenced this issue


          ✅ [#4969] Add story for steps tab

4b199f4

sergei-maertens added a commit that referenced this issue


          🚸 [#4969] Collapse form definition settings to declutter

8a7354e

If a name and slug (required fields) are provided, the fieldset is
collapsed.

sergei-maertens added a commit that referenced this issue


          ✅ [#4969] Add story to ensure fieldset is expanded if there are errors

6411b03

sergei-maertens closed this as completed in #4979

github-project-automation bot moved this from In Progress to Done in Development

sergei-maertens reopened this

github-project-automation bot moved this from Done to In Progress in Development

sergei-maertens added a commit that referenced this issue


          🐛 [#4969] Add missing natural key support to map tile layer model

c135dd4

sergei-maertens added a commit that referenced this issue


          ✨ [#4969] Ensure map tile layers are loaded on deploy

4d9b8ea

Set up a post-migrate hook to load the map tile layers fixture.

sergei-maertens mentioned this issue

Load map tile layers fixture automatically #4982

Merged

10 tasks

sergei-maertens closed this as completed in #4982

github-project-automation bot moved this from In Progress to Done in Development

sergei-maertens reopened this

github-project-automation bot moved this from Done to In Progress in Development

sergei-maertens removed the triage label

Member

sergei-maertens commented Jan 2, 2025

Submission limits seem to reset when saving the form

Set a submission limit of 1 on a form
Create a valid submission for the form
Verify that starting a new form submission is not possible
Save the form again in the admin without modifying anything
You can now start a new submission again, which should not be possible

sergei-maertens added a commit that referenced this issue


          🧪 [#4969] Add regression test for accidental counter reset

9c5395c

sergei-maertens added a commit that referenced this issue


          🐛 [#4969] Exclude the submission counter when saving a form

0440daa

If the GET data is stale while the form is loaded in the admin, counter
updates done between loading-and-saving are dropped and overwritten
with the stale counter.

Dropping this key entirely (since it's optional anyway) is the easiest
way to prevent this.

sergei-maertens mentioned this issue

Fix accidental submission counter reset #4983

Merged

10 tasks

sergei-maertens closed this as completed in #4983

github-project-automation bot moved this from In Progress to Done in Development

sergei-maertens reopened this

github-project-automation bot moved this from Done to In Progress in Development

sergei-maertens closed this as completed

github-project-automation bot moved this from In Progress to Done in Development

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment