Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OTel Hook] Add custom-dimensions support to Metrics Hook #118

Open
3 tasks
toddbaert opened this issue Dec 18, 2023 · 2 comments
Open
3 tasks

[OTel Hook] Add custom-dimensions support to Metrics Hook #118

toddbaert opened this issue Dec 18, 2023 · 2 comments
Labels
contribfest A good issue for Contribfest KubeCon EU '24 good first issue Good for newcomers help wanted Extra attention is needed

Comments

@toddbaert
Copy link
Member

toddbaert commented Dec 18, 2023

Support the addition of adding custom dimensions (attributes) to the evaluation_success_total metric. This is done by allowing users to define a function to extract dimensions from flag metadata.

Here is the equivalent Java implementation.

Task:

  • implement functionality
  • add relevant tests
  • add associated documentation
@toddbaert toddbaert added good first issue Good for newcomers help wanted Extra attention is needed labels Dec 18, 2023
@askpt
Copy link
Member

askpt commented Dec 21, 2023

I'll look into this one @toddbaert

@toddbaert toddbaert added contribfest A good issue for Contribfest KubeCon EU '24 and removed contribfest A good issue for Contribfest KubeCon EU '24 labels Mar 11, 2024
@toddbaert
Copy link
Member Author

toddbaert commented Mar 15, 2024

@askpt I'm going to unassign this from you because it's a good issue for our KubeCon contribfest. If you decide you'd like to work on it sooner though, or you have work pending, just reassign yourself or let me know.

There will be lots of other work incoming with spec v0.8.0 as well 😅. I'll be creating issues for that.

@toddbaert toddbaert added the contribfest A good issue for Contribfest KubeCon EU '24 label Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribfest A good issue for Contribfest KubeCon EU '24 good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants