Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect data type for BreakoutAnalogOutput #205

Closed
jonnew opened this issue Aug 12, 2024 · 1 comment · Fixed by #213
Closed

Incorrect data type for BreakoutAnalogOutput #205

jonnew opened this issue Aug 12, 2024 · 1 comment · Fixed by #213
Assignees
Labels
bug Something isn't working critical This is a blocking issue affecting all users
Milestone

Comments

@jonnew
Copy link
Member

jonnew commented Aug 12, 2024

The analog outputs on the breakout board requires unsigned 16-bit integer data that is interpreted by the hardware as offset binary:

https://open-ephys.github.io/onix-docs/Hardware%20Guide/Datasheets/fmc-analog-io.html#host-to-device-data-frames

However, signed data is used throughout the output node resulting in incorrect values being sent to the hardware:

https://github.com/open-ephys/onix-bonsai-onix1/blob/7ac700fb8a696d4d9f8d97c9d1b85765b9951ca6/OpenEphys.Onix1/BreakoutAnalogOutput.cs#L100

This issue applies to both Volts and S16 output options because they are both ultimately transformed to S16 before being sent.

image

@jonnew jonnew added bug Something isn't working critical This is a blocking issue affecting all users labels Aug 12, 2024
@jonnew jonnew added this to the 0.2.0 milestone Aug 12, 2024
@jonnew
Copy link
Member Author

jonnew commented Aug 14, 2024

Fixed in #213

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working critical This is a blocking issue affecting all users
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants