Skip to content

Commit b0bc622

Browse files
committed
Address review comments
- Remove self-referential cref to DataType in XML docs
1 parent 6b61f1d commit b0bc622

File tree

2 files changed

+35
-25
lines changed

2 files changed

+35
-25
lines changed

OpenEphys.Onix1/BreakoutAnalogOutput.cs

Lines changed: 26 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -29,26 +29,29 @@ public class BreakoutAnalogOutput : Sink<Mat>
2929
/// Gets or sets the data type used to represent analog samples.
3030
/// </summary>
3131
/// <remarks>
32-
/// If <see cref="BreakoutAnalogIODataType.S16"/> is selected, each DAC value is represented by a signed, twos-complement encoded
33-
/// 16-bit integer. In this case, the output voltage always corresponds to <see cref="BreakoutAnalogIOVoltageRange.TenVolts"/>.
34-
/// When <see cref="BreakoutAnalogIODataType.Volts"/> is selected, 32-bit floating point voltages between -10 and 10 volts are sent
35-
/// directly to the DACs.
32+
/// If <see cref="BreakoutAnalogIODataType.S16"/> is selected, each DAC value is represented by a
33+
/// signed, twos-complement encoded 16-bit integer. In this case, the output voltage always
34+
/// corresponds to <see cref="BreakoutAnalogIOVoltageRange.TenVolts"/>. When <see
35+
/// cref="BreakoutAnalogIODataType.Volts"/> is selected, 32-bit floating point voltages between -10
36+
/// and 10 volts are sent directly to the DACs.
3637
/// </remarks>
3738
[Description("The data type used to represent analog samples.")]
3839
[Category(DeviceFactory.ConfigurationCategory)]
3940
public BreakoutAnalogIODataType DataType { get; set; } = BreakoutAnalogIODataType.S16;
4041

4142
/// <summary>
42-
/// Send a matrix of samples to analog outputs
43+
/// Send an matrix of samples to all enabled analog outputs.
4344
/// </summary>
4445
/// <remarks>
45-
/// If a matrix contains multiple samples, they will be written to hardware as quickly as communication allows.
46-
/// The data within each input matrix must have <see cref="Depth.S16"/> when <see
47-
/// cref="DataType"/> is set to <see cref="BreakoutAnalogIODataType.S16"/> or <see cref="Depth.F32"/>
48-
/// when <see cref="DataType"/> is set to <see cref="BreakoutAnalogIODataType.Volts"/>.
46+
/// If a matrix contains multiple samples, they will be written to hardware as quickly as
47+
/// communication allows. The data within each input matrix must have <see cref="Depth.S16"/> when
48+
/// <c>DataType</c> is set to <see cref="BreakoutAnalogIODataType.S16"/> or <see cref="Depth.F32"/>
49+
/// when <c>DataType</c> is set to <see cref="BreakoutAnalogIODataType.Volts"/>.
4950
/// </remarks>
50-
/// <param name="source"> A sequence of 12xN sample matrices containing the analog data to write to channels 0 to 11.</param>
51-
/// <returns> A sequence of 12xN sample matrices containing the analog data that were written to channels 0 to 11.</returns>
51+
/// <param name="source"> A sequence of 12xN sample matrices containing the analog data to write to
52+
/// channels 0 to 11.</param>
53+
/// <returns> A sequence of 12xN sample matrices containing the analog data that were written to
54+
/// channels 0 to 11.</returns>
5255
public override unsafe IObservable<Mat> Process(IObservable<Mat> source)
5356
{
5457
var dataType = DataType;
@@ -109,15 +112,17 @@ public override unsafe IObservable<Mat> Process(IObservable<Mat> source)
109112
}
110113

111114
/// <summary>
112-
/// Send an 12-element array of values to update all analog outputs.
115+
/// Send an 12-element array of values to update all enabled analog outputs.
113116
/// </summary>
114117
/// <remarks>
115-
/// This overload should be used when <see cref="DataType"/> is set to <see
118+
/// This overload should be used when <c>DataType</c> is set to <see
116119
/// cref="BreakoutAnalogIODataType.S16"/> and values should be within -32,768 to 32,767, which
117120
/// correspond to -10.0 to 10.0 volts.
118121
/// </remarks>
119-
/// <param name="source"> A sequence of 12x1 element arrays each containing the analog data to write to channels 0 to 11.</param>
120-
/// <returns> A sequence of 12x1 element arrays each containing the analog data to write to channels 0 to 11.</returns>
122+
/// <param name="source"> A sequence of 12x1 element arrays each containing the analog data to write
123+
/// to channels 0 to 11.</param>
124+
/// <returns> A sequence of 12x1 element arrays each containing the analog data to write to channels 0
125+
/// to 11.</returns>
121126
public IObservable<short[]> Process(IObservable<short[]> source)
122127
{
123128
if (DataType != BreakoutAnalogIODataType.S16)
@@ -141,14 +146,16 @@ public IObservable<short[]> Process(IObservable<short[]> source)
141146
}
142147

143148
/// <summary>
144-
/// Send an 12-element array of values to update all analog outputs.
149+
/// Send an 12-element array of values to update all enabled analog outputs.
145150
/// </summary>
146151
/// <remarks>
147-
/// This overload should be used when <see cref="DataType"/> is set to <see
152+
/// This overload should be used when <c>DataType</c> is set to <see
148153
/// cref="BreakoutAnalogIODataType.Volts"/> and values should be within -10.0 to 10.0 volts.
149154
/// </remarks>
150-
/// <param name="source"> A sequence of 12x1 element arrays each containing the analog data to write to channels 0 to 11.</param>
151-
/// <returns> A sequence of 12x1 element arrays each containing the analog data to write to channels 0 to 11.</returns>
155+
/// <param name="source"> A sequence of 12x1 element arrays each containing the analog data to write
156+
/// to channels 0 to 11.</param>
157+
/// <returns> A sequence of 12x1 element arrays each containing the analog data to write to channels 0
158+
/// to 11.</returns>
152159
public IObservable<float[]> Process(IObservable<float[]> source)
153160
{
154161
if (DataType != BreakoutAnalogIODataType.Volts)

OpenEphys.Onix1/ConfigureBreakoutDigitalIO.cs

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ namespace OpenEphys.Onix1
1111
/// cref="BreakoutDigitalInput"/> and <see cref="BreakoutDigitalOutput"/>, using a shared
1212
/// <c>DeviceName</c>.
1313
/// </remarks>
14-
[Description("onfigures the ONIX breakout board's digital inputs and outputs.")]
14+
[Description("Configures the ONIX breakout board's digital inputs and outputs.")]
1515
public class ConfigureBreakoutDigitalIO : SingleDeviceFactory
1616
{
1717
/// <summary>
@@ -27,7 +27,8 @@ public ConfigureBreakoutDigitalIO()
2727
/// Gets or sets the device enable state.
2828
/// </summary>
2929
/// <remarks>
30-
/// If set to true, <see cref="BreakoutDigitalInput"/> will produce data. If set to false, <see cref="BreakoutDigitalInput"/> will not produce data.
30+
/// If set to true, <see cref="BreakoutDigitalInput"/> will produce data. If set to false, <see
31+
/// cref="BreakoutDigitalInput"/> will not produce data.
3132
/// </remarks>
3233
[Category(ConfigurationCategory)]
3334
[Description("Specifies whether the digital IO device is enabled.")]
@@ -37,12 +38,14 @@ public ConfigureBreakoutDigitalIO()
3738
/// Configures the digital input and output device in the ONIX breakout board.
3839
/// </summary>
3940
/// <remarks>
40-
/// This will schedule digital IO hardware configuration actions that can be applied by a
41-
/// <see cref="StartAcquisition"/> object prior to data collection.
41+
/// This will schedule digital IO hardware configuration actions that can be applied by a <see
42+
/// cref="StartAcquisition"/> object prior to data collection.
4243
/// </remarks>
43-
/// <param name="source">A sequence of <see cref="ContextTask"/> instances that hold configuration actions.</param>
44+
/// <param name="source">A sequence of <see cref="ContextTask"/> instances that hold configuration
45+
/// actions.</param>
4446
/// <returns>
45-
/// The original sequence modified by adding additional configuration actions required to configure a digital IO device.
47+
/// The original sequence modified by adding additional configuration actions required to configure a
48+
/// digital IO device.
4649
/// </returns>
4750
public override IObservable<ContextTask> Process(IObservable<ContextTask> source)
4851
{

0 commit comments

Comments
 (0)