Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor data element classes #111

Open
ZviBaratz opened this issue Jul 26, 2022 · 0 comments
Open

Refactor data element classes #111

ZviBaratz opened this issue Jul 26, 2022 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed
Milestone

Comments

@ZviBaratz
Copy link
Collaborator

Currently, dicom_parser uses the dicom_parser.data_elements module to create individual classes for each DICOM value representation (VR) and implement custom parsing functionality. This decision was made in a rush with the intention to enable easier integration with django_dicom and more flexibility implementing custom parsing functionality. In practice, most VRs do not require any custom parsing functionality, and therefore the module mostly clutters and complicates the code base with numerous empty wrapper classes that do not add anything to pydicom's existing functionality.
It would be much better if the existing functionality could be achieved without all the empty classes.

@ZviBaratz ZviBaratz added enhancement New feature or request help wanted Extra attention is needed labels Jul 26, 2022
@ZviBaratz ZviBaratz added this to the v1.3.0 milestone Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant