You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, dicom_parser uses the dicom_parser.data_elements module to create individual classes for each DICOM value representation (VR) and implement custom parsing functionality. This decision was made in a rush with the intention to enable easier integration with django_dicom and more flexibility implementing custom parsing functionality. In practice, most VRs do not require any custom parsing functionality, and therefore the module mostly clutters and complicates the code base with numerous empty wrapper classes that do not add anything to pydicom's existing functionality.
It would be much better if the existing functionality could be achieved without all the empty classes.
The text was updated successfully, but these errors were encountered:
Currently,
dicom_parser
uses thedicom_parser.data_elements
module to create individual classes for each DICOM value representation (VR) and implement custom parsing functionality. This decision was made in a rush with the intention to enable easier integration withdjango_dicom
and more flexibility implementing custom parsing functionality. In practice, most VRs do not require any custom parsing functionality, and therefore the module mostly clutters and complicates the code base with numerous empty wrapper classes that do not add anything topydicom
's existing functionality.It would be much better if the existing functionality could be achieved without all the empty classes.
The text was updated successfully, but these errors were encountered: