From 4d19ec72c3fad629a9a52ea21d90b337966ceb6c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=A9gis=20Behmo?= Date: Mon, 30 Oct 2023 10:15:12 +0100 Subject: [PATCH] fix: auto-build images in nightly MFE images were not automatically built in nightly: this occurred both in local and dev mode. Close #157 --- tutormfe/plugin.py | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tutormfe/plugin.py b/tutormfe/plugin.py index 83465cf6..7df6b8f3 100644 --- a/tutormfe/plugin.py +++ b/tutormfe/plugin.py @@ -207,12 +207,12 @@ def _print_mfe_public_hosts( def _build_3rd_party_dev_mfes_on_launch( image_names: list[str], context_name: t.Literal["local", "dev"] ) -> list[str]: - if context_name == "dev": - for mfe_name, _mfe_attrs in iter_mfes(): - if mfe_name not in CORE_MFE_APPS: - # We don't require to build core MFEs because images are available from - # the public registry. - image_names.append(f"{mfe_name}-dev") + for mfe_name, _mfe_attrs in iter_mfes(): + if __version_suffix__ or (context_name == "dev" and mfe_name not in CORE_MFE_APPS): + # We build MFE images: + # - in nightly + # - in development for non-core apps + image_names.append(f"{mfe_name}-dev") return image_names