Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid sa_column where possible #239

Closed
2 tasks done
jpmckinney opened this issue Dec 6, 2023 · 1 comment · Fixed by #373
Closed
2 tasks done

Avoid sa_column where possible #239

jpmckinney opened this issue Dec 6, 2023 · 1 comment · Fixed by #373
Assignees
Labels
chore topic: models Relating to the ORM or database integration

Comments

@jpmckinney
Copy link
Member

jpmckinney commented Dec 6, 2023

It can cause programmer errors like in #235.

@jpmckinney jpmckinney changed the title Check if sa_column can be avoided Avoid sa_column where possible Dec 6, 2023
@jpmckinney
Copy link
Member Author

jpmckinney commented Dec 19, 2023

When making changes to Decimal in #238, we had changed the type annotation from Decimal to our custom type FLOAT_DECIMAL 56ea76a, based on this documentation: https://docs.pydantic.dev/latest/api/standard_library_types/#decimaldecimal

Relevant comments:

@jpmckinney jpmckinney added the topic: models Relating to the ORM or database integration label Dec 19, 2023
@yolile yolile moved this to 📋 Backlog in Credere optimization backlog May 7, 2024
@jpmckinney jpmckinney self-assigned this Aug 17, 2024
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Credere optimization backlog Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore topic: models Relating to the ORM or database integration
Projects
No open projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

1 participant