-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
movies shorter than 1s give an error #4
Comments
It was intended to be a failsafe for when people try to load corrupted movies (they have no duration indication), or files that are no movie at all. I never expected anyone to play videos shorter than 1 second. If it doesn't break anything in your case, I will consider removing this check, although I should test a couple of edge-case scenarios first... |
Maybe change the value to something really small like 0.0001? |
Yes, or maybe even 0.5s would suffice. I doubt people will ever want to play movies shorter than that (or maybe I'm falling into the same trap again). |
Still haven't had a chance to look at this, but it's not gone from my radar... |
When playing movies that are shorter than 1s I get an error about the max_duration in timer.py:
max_duration needs to be greater than 1.0
The goal of this condition is unclear to me. Removing the condition fixes the problem (but maybe creates problems in other cases).
The text was updated successfully, but these errors were encountered: