Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

movies shorter than 1s give an error #4

Open
dev-jam opened this issue Jun 19, 2018 · 4 comments
Open

movies shorter than 1s give an error #4

dev-jam opened this issue Jun 19, 2018 · 4 comments

Comments

@dev-jam
Copy link

dev-jam commented Jun 19, 2018

When playing movies that are shorter than 1s I get an error about the max_duration in timer.py:

max_duration needs to be greater than 1.0

The goal of this condition is unclear to me. Removing the condition fixes the problem (but maybe creates problems in other cases).

@dschreij
Copy link
Member

It was intended to be a failsafe for when people try to load corrupted movies (they have no duration indication), or files that are no movie at all. I never expected anyone to play videos shorter than 1 second. If it doesn't break anything in your case, I will consider removing this check, although I should test a couple of edge-case scenarios first...

@dev-jam
Copy link
Author

dev-jam commented Jun 26, 2018

Maybe change the value to something really small like 0.0001?

@dschreij
Copy link
Member

Yes, or maybe even 0.5s would suffice. I doubt people will ever want to play movies shorter than that (or maybe I'm falling into the same trap again).
Would it be possible for you to play around with this setting, test if it works correctly and submit a PR? Otherwise I'll see if I can work on this in the weekend.

@dschreij
Copy link
Member

Still haven't had a chance to look at this, but it's not gone from my radar...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants