Skip to content

Commit ff3d34c

Browse files
committed
Upgrade the API to use the latest Selenium Webdriver
1 parent 2d05d93 commit ff3d34c

File tree

3 files changed

+5
-13
lines changed

3 files changed

+5
-13
lines changed

Gemfile

+2-2
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,8 @@ gem 'eventmachine', github: 'eventmachine/eventmachine'
2020
gem 'thin', github: 'macournoyer/thin' unless RUBY_PLATFORM =~ /mingw/
2121

2222
# runner
23-
gem 'selenium-webdriver', require: false
23+
gem 'selenium-webdriver', '>= 4.14.0', require: false
2424
gem 'rest-client', require: false
25-
gem 'webdrivers', require: false
2625
gem 'rexml', require: false
2726
gem 'ffi'
2827

@@ -38,3 +37,4 @@ else
3837
gem 'opal', github: 'opal/opal', ref: ENV['OPAL_VERSION']
3938
end
4039

40+
gem 'opal-sprockets'

Rakefile

+2-9
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@ require 'bundler'
22
Bundler.require
33
require 'bundler/gem_tasks'
44

5-
require 'webdrivers'
6-
load 'webdrivers/Rakefile'
7-
85
require 'opal/rspec/rake_task'
96
Opal::RSpec::RakeTask.new(:broken_rspec) do |_, task|
107
task.default_path = 'spec'
@@ -14,12 +11,8 @@ end
1411
task(:nil) {}
1512

1613
%w[chrome edge gecko safari].each do |i|
17-
dependency = nil
18-
if %w[chrome edge gecko].include? i
19-
dependency = "webdrivers:#{i}driver:update"
20-
end
2114
desc "Run Selenium tests with #{i}"
22-
task :"selenium_#{i}" => dependency do
15+
task :"selenium_#{i}" do
2316
server = Process.spawn("bundle", "exec", "rackup")
2417
at_exit { Process.kill(9, server) rescue nil }
2518
sleep 2
@@ -60,4 +53,4 @@ task :build_gh_pages do
6053
HTML
6154
end
6255
end
63-
end
56+
end

spec/runner.rb

+1-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
#! /usr/bin/env ruby
2-
require 'webdrivers'
32
require 'selenium/webdriver'
43
require 'rest_client'
54
require 'json'
@@ -23,7 +22,7 @@
2322
raise "Wrong web browser provided in BROWSER. Acceptable values: chrome, gecko, safari, edge"
2423
end
2524

26-
browser = Selenium::WebDriver.for(browser, capabilities: options)
25+
browser = Selenium::WebDriver.for(browser, options: options)
2726
browser.navigate.to('http://localhost:9292')
2827

2928
# if we don't quit the browser it will stall

0 commit comments

Comments
 (0)