Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target .NET Standard 2.0 to Support .NET Core Build #222

Open
ab-tools opened this issue May 13, 2020 · 6 comments · May be fixed by #230
Open

Target .NET Standard 2.0 to Support .NET Core Build #222

ab-tools opened this issue May 13, 2020 · 6 comments · May be fixed by #230

Comments

@ab-tools
Copy link

Do you consider to change the target framework to .NET Standard 2.0 to also support .NET Core using this library?

@oozcitak
Copy link
Owner

This is not possible since there is no winforms (System.Windows.Forms) in .NET Standard.

@ab-tools
Copy link
Author

Sorry, you indeed can't target .NET Standard with a WinForms project, but you need to target .NET Core directly instead:
WinForms is supported in .NET Core in .NET Core 3.x.

It would therefore be great if you could (additionally to .NET Framework) also target .NET Core with your library. Thanks!

@oozcitak
Copy link
Owner

Would you be interested in sending a PR?

@oozcitak oozcitak reopened this Jun 16, 2020
@ab-tools
Copy link
Author

Done here:
#223

It was in fact much simpler than I thought as the code compiled without any problems under .NET 3.1 without any code changes needed:
So I just added two .NET Core 3.1 projects to the solution now - that's it. :-)

@oozcitak
Copy link
Owner

oozcitak commented Jun 17, 2020

Thank you. I'll look into this today. Just a quick comment though. I thought it was possible to target multiple frameworks in a single .csproj. Is this not the case? Anyway, I'll review and get back to you.

@ab-tools
Copy link
Author

ab-tools commented Nov 5, 2020

Did you have the chance to take a look on this, @oozcitak?

Actually it might be best to provide a Core version of ImageListView as a separate NuGet package or what do you think?

@peymanr34 peymanr34 linked a pull request Jul 14, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants