Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oohttp: add header ordering support #2160

Closed
fedosgad opened this issue Jun 22, 2022 · 6 comments
Closed

oohttp: add header ordering support #2160

fedosgad opened this issue Jun 22, 2022 · 6 comments
Assignees
Labels
data quality discuss Needs discussion before proceeding enhancement New feature request or improvement to existing functionality methodology issues related to the testing methodology needs investigation This issue needs extra data and investigation ooni/probe-engine priority/low Nice to have user feedback requests that have been added to the backlog as a direct result of user feedback or testing wishlist

Comments

@fedosgad
Copy link

fedosgad commented Jun 22, 2022

I have forked oohttp (this is a great library btw, thanks a lot for it!) to add support for features absent in stdlib's http client, such as header ordering (including HTTP2 headers and pseudoheaders), manipulating HTTP2 settings and HTTP2 SERVER PUSH. My intent is to make mimicking "normal" web browsers (Chrome/FF/you name it) simplier and more accurate.

Code is available at github.com/fedosgad/oohttp. Currently, I've finished header ordering (ported from fhttp).

Changes were made in (I hope) maintainable way, similar to what oohttp itself has done (see PATCHING.md). I would like to contribute those changes back to oohttp. What do you think about it?

@bassosimone
Copy link
Contributor

Absolutely! I'll add to my sprint to take a look at your changes, thank you!

@bassosimone bassosimone self-assigned this Jun 23, 2022
@bassosimone bassosimone added the discuss Needs discussion before proceeding label Jun 23, 2022
@bassosimone bassosimone added enhancement New feature request or improvement to existing functionality wishlist priority/medium Normal priority issue user feedback requests that have been added to the backlog as a direct result of user feedback or testing methodology issues related to the testing methodology data quality needs investigation This issue needs extra data and investigation ooni/probe-engine labels Jun 23, 2022
@bassosimone bassosimone changed the title oohttp: Add header ordering support oohttp: add header ordering support Jun 23, 2022
@fedosgad
Copy link
Author

That's great! Feel free to ping me if there are any questions.

@bassosimone bassosimone added priority/low Nice to have and removed priority/medium Normal priority issue labels Aug 8, 2022
@nathanejohnson
Copy link

I am very much interested in seeing this get rolled in. @bassosimone would it be helpful for me to put together a PR, or is this something you've already started on?

@bassosimone
Copy link
Contributor

@nathanejohnson it seems there is already an open PR: ooni/oohttp#46

@hellais hellais added this to Roadmap Jan 7, 2025
@hellais
Copy link
Member

hellais commented Jan 28, 2025

Unfortunately we are going to be discontinuing our oohttp golang std lib http fork, as it's too expensive for us to maintain.

As a result I am closing this issue.

@hellais hellais closed this as not planned Won't fix, can't repro, duplicate, stale Jan 28, 2025
@github-project-automation github-project-automation bot moved this to Done in Roadmap Jan 28, 2025
@fedosgad
Copy link
Author

Sad to hear this but thanks for the early warning!
Do you mind sharing what libraries you will use instead of oohttp?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data quality discuss Needs discussion before proceeding enhancement New feature request or improvement to existing functionality methodology issues related to the testing methodology needs investigation This issue needs extra data and investigation ooni/probe-engine priority/low Nice to have user feedback requests that have been added to the backlog as a direct result of user feedback or testing wishlist
Projects
Archived in project
Development

No branches or pull requests

4 participants