Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace usage of electron.remote with more explicit IPC #1349

Closed
sarathms opened this issue Feb 10, 2021 · 2 comments
Closed

Replace usage of electron.remote with more explicit IPC #1349

sarathms opened this issue Feb 10, 2021 · 2 comments
Assignees
@majakomel
Labels
enhancement New feature request or improvement to existing functionality ooni/probe-desktop priority/medium Normal priority issue

Comments

@sarathms
Copy link

Currently we use electron's remote module to perform key background operations like updating configuration, loading measurement data. This isn't a safe practice anymore and newer versions of electron discourage using the module. We should instead use contextIsolation and other recommdendations here to move away from this.

This also prevents us from upgrading electron and leverage some other useful features.
@sarathms sarathms added effort/L enhancement New feature request or improvement to existing functionality ooni/probe-desktop labels Feb 10, 2021
@sarathms sarathms added this to the Sprint 33 - Actinia equina milestone Feb 10, 2021
@sarathms sarathms self-assigned this Feb 10, 2021
@sarathms sarathms added the priority/medium Normal priority issue label Feb 17, 2021
@hellais
Copy link
Member

hellais commented Jul 14, 2021

This is 90% done.

@sarathms sarathms removed this from the Sprint 44 - Dancing Sirens milestone Aug 2, 2021
@sarathms sarathms added this to the Sprint 45 - Antarctic Krill milestone Aug 2, 2021
@hellais hellais removed this from the Sprint 50 - Amphipoda milestone Oct 25, 2021
@hellais hellais removed the effort/L label Jan 31, 2022
@bassosimone bassosimone assigned majakomel and unassigned sarathms Apr 6, 2023
@hellais hellais added this to Roadmap Jan 7, 2025
@hellais
Copy link
Member

hellais commented Jan 27, 2025

Superseeded by #2845

@hellais hellais closed this as completed Jan 27, 2025
@github-project-automation github-project-automation bot moved this to Done in Roadmap Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@majakomel majakomel

Labels
enhancement New feature request or improvement to existing functionality ooni/probe-desktop priority/medium Normal priority issue
Projects
Roadmap
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bassosimone @hellais @sarathms @majakomel