From 26a49ca9b07ddfaf72cfed5bfc4c6cfeffde9e9d Mon Sep 17 00:00:00 2001 From: DecFox <33030671+DecFox@users.noreply.github.com> Date: Wed, 7 Aug 2024 01:32:00 +0530 Subject: [PATCH] refactor: remove dnscheck loader (#1640) ## Checklist - [x] I have read the [contribution guidelines](https://github.com/ooni/probe-cli/blob/master/CONTRIBUTING.md) - [ ] reference issue for this pull request: - [ ] if you changed anything related to how experiments work and you need to reflect these changes in the ooni/spec repository, please link to the related ooni/spec pull request: - [ ] if you changed code inside an experiment, make sure you bump its version number ## Description This diff refactors the dnscheck factory to use the default target loader --- docs/design/dd-008-richer-input.md | 2 +- internal/registry/dnscheck.go | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/docs/design/dd-008-richer-input.md b/docs/design/dd-008-richer-input.md index f0a53aaf4..469248a97 100644 --- a/docs/design/dd-008-richer-input.md +++ b/docs/design/dd-008-richer-input.md @@ -4,7 +4,7 @@ |--------------|------------------------------------------------| | Author | [@bassosimone](https://github.com/bassosimone) | | Last-Updated | 2024-07-02 | -| Reviewed-by | [@DecFox](https://github.com/DecFox | +| Reviewed-by | [@DecFox](https://github.com/DecFox) | | Status | living document | This document is a living document documenting our in-progress design diff --git a/internal/registry/dnscheck.go b/internal/registry/dnscheck.go index 009078aa6..2af708017 100644 --- a/internal/registry/dnscheck.go +++ b/internal/registry/dnscheck.go @@ -22,7 +22,6 @@ func init() { config: &dnscheck.Config{}, enabledByDefault: true, inputPolicy: model.InputOrStaticDefault, - newLoader: dnscheck.NewLoader, } } }