Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fail gracefully when parsing config #69

Open
ainghazal opened this issue Feb 21, 2024 · 0 comments
Open

fail gracefully when parsing config #69

ainghazal opened this issue Feb 21, 2024 · 0 comments
Assignees
@ainghazal

Comments

@ainghazal
Copy link
Collaborator

since this is public API, we should propagate parsing errors on the constructor.

See comments during #68 code review:
#68 (comment)
@ainghazal ainghazal self-assigned this Feb 21, 2024
@ainghazal ainghazal mentioned this issue Feb 21, 2024
Merged
3 tasks
ainghazal added a commit to ainghazal/minivpn that referenced this issue Mar 6, 2024
@ainghazal
refactor: fail gracefully while parsing config
1259ed8 
the Options object is now a function that also returns an error. The
NewConfig() constructor checks for errors and returns it, if any.

- Resolves: ooni#69
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ainghazal ainghazal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ainghazal