From 04e808d8f524568e43fd0611fc6db026cfd8be51 Mon Sep 17 00:00:00 2001
From: Kevin Cui <bh@bugs.cc>
Date: Fri, 25 Oct 2024 16:11:53 +0800
Subject: [PATCH] fix(sign): cannot notarize (#6)

When notarizing the APP, it's necessary to add `--options=runtime`.

At the same time, the issue of krun not being able to load dylib through
env has been fixed, along with some spelling errors.

Signed-off-by: Kevin Cui <bh@bugs.cc>
---
 krunkit.entitlements | 4 +++-
 main.sh              | 6 +++---
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/krunkit.entitlements b/krunkit.entitlements
index a967593..bf7406e 100644
--- a/krunkit.entitlements
+++ b/krunkit.entitlements
@@ -4,7 +4,9 @@
 <dict>
 	<key>com.apple.security.hypervisor</key>
 	<true/>
-	<key>com.apple.security.cs.disable-library-validationr</key>
+	<key>com.apple.security.cs.disable-library-validation</key>
+	<true/>
+	<key>com.apple.security.cs.allow-dyld-environment-variables</key>
 	<true/>
 </dict>
 </plist>
diff --git a/main.sh b/main.sh
index 93d2a32..f6e9435 100755
--- a/main.sh
+++ b/main.sh
@@ -40,12 +40,12 @@ cd $WORK
 
 # codesign
 echo "Signing gvproxy..."
-codesign --force --sign $CODESIGN_IDENTITY --timestamp $WORK/out/gvproxy
+codesign --force --sign $CODESIGN_IDENTITY --options=runtime --timestamp $WORK/out/gvproxy
 
 echo "Signing krunkit..."
-codesign --force --sign $CODESIGN_IDENTITY --timestamp --entitlements krunkit.entitlements $WORK/out/krunkit
+codesign --force --sign $CODESIGN_IDENTITY --options=runtime --timestamp --entitlements krunkit.entitlements $WORK/out/krunkit
 
-find $WORK/out -name "*.dylib" -type f -exec sh -c "echo 'Signing {}...'; codesign --force --sign $CODESIGN_IDENTITY --timestamp {}" ';'
+find $WORK/out -name "*.dylib" -type f -exec sh -c "echo 'Signing {}...'; codesign --force --sign $CODESIGN_IDENTITY --options=runtime --timestamp {}" ';'
 
 # pack
 echo "Packing..."