Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FilterIndex after ShowDialog of Save Dialog #45

Open
barnacleboy opened this issue Apr 22, 2021 · 1 comment
Open

Update FilterIndex after ShowDialog of Save Dialog #45

barnacleboy opened this issue Apr 22, 2021 · 1 comment
Labels
enhancement New feature or request hacktoberfest https://hacktoberfest.digitalocean.com help wanted Extra attention is needed up-for-grabs
Milestone

Comments

@barnacleboy
Copy link

Hi there!

Thanks for maintaining the good old ookii-dialogs assemblies! I would suggest the following enhancement:

Think of the scenario where you have a Save Dialog that has the following 2 filters:

  • XML file version 1
  • XML file version 2

Both filters have the same extension (XML) but after defining the file name in the dialog, you want to know which filter index was set in the dialog to decide if we save the XML in version 1 or version 2 of the data format.

After debugging and scrolling through the code, I've found out that the VistaSaveFileDialog never gets the filter index back after FileOk - unfortunately there are also no possibilites to customize the behavior manually, since the FileOk event only provides the CancelEventArgs.

I think this would be a good addition to the File Dialogs since I remember this worked in the original ones from Microsoft. Best place to implement this would be the GetResult method I guess...

Regards,
barnacleboy

@augustoproiete augustoproiete added the enhancement New feature or request label Apr 22, 2021
@augustoproiete
Copy link
Member

Thanks @barnacleboy. That makes sense to me.

Feel free to submit a PR, otherwise I'll get to it when I have a chance.

@augustoproiete augustoproiete added help wanted Extra attention is needed up-for-grabs labels Apr 22, 2021
@augustoproiete augustoproiete added this to the Future milestone Sep 5, 2021
@augustoproiete augustoproiete added the hacktoberfest https://hacktoberfest.digitalocean.com label Oct 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest https://hacktoberfest.digitalocean.com help wanted Extra attention is needed up-for-grabs
Development

No branches or pull requests

2 participants