Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom purchasable support #5

Open
timeverts opened this issue Jan 24, 2020 · 3 comments
Open

Add custom purchasable support #5

timeverts opened this issue Jan 24, 2020 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@timeverts
Copy link

Having had a brief look at your code, unless I'm mistaken, it doesn't appear as though custom purchasables can be included within product bundles.

Some examples of custom purchasables are:

All custom purchasables extend the same craft\commerce\base\Purchasable class. The default Commerce product (which is actually a Variant) extends this class too, so it's really a custom purchasable itself.

If you want to see an example of supporting custom purchasables, take a look at the Promotions section in Commerce.

@jerome2710
Copy link
Contributor

Thank you for your description, I think you are right. I will look into this and try to fix it.

@jerome2710 jerome2710 added the enhancement New feature or request label Feb 5, 2020
@jerome2710 jerome2710 self-assigned this Feb 5, 2020
@timeverts
Copy link
Author

@jerome2710, do you still have plans/capability to implement custom purchasable support?

@jerome2710
Copy link
Contributor

@timeverts I have looked briefly into this. Given the fact that for product bundles you would like to give the user the ability to pick a variant, it is not possible to migrate to purchasables. A product is not a purchasable, but the variants underneath it are. Therefore I got stuck finding the correct relations.

If you have a suggestion, I'm happy to look into this again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

2 participants