-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ONVIF enforcing 'default' device requirement for discovery? #520
Comments
@bsriramprasad Have you raised this also to @madhurao68 in the Testing WG to get Feed back from GRSE? GRSE feed back is often very useful and vital input before we address this issue that you have raised. Personally I feel that each ONVIF device that is being tested by the DTT should be in discoverable mode under WS-DISCOVERY if being tested by DTT or Taken out of a shrink wrapped box and switched on for the first time. If you are saying that "SetSystemFactoryDefault" does not set the discoverable flag after being called then that is a bug that should be resolved on the Vendor side not in the DTT. The DTT tests ONVIF Conformance regardless of Vendor. |
GRSE doesn't act independently and needs guidance from WG to do any test modification or spec clarifications and hence raised it here to enable discussion.
|
@bsriramprasad While I respect your opinion and have agreed with you on many issues openly. I feel my opinion is valid and does count as per stated above in response to your issue. "GRSE doesn't act independently and needs guidance from WG to do any test modification or spec clarifications and hence raised it here to enable discussion." I am not a stranger to GRSE's function Sir!. And yes I feel a wider discussion is valuable and admirable. "SetSystemFactoryDefault" does not set the discoverable flag after being called. As you have stated it does not say explicitly! about discoverable flag but when a device is taken out of the box or set for discovery testing with DTT is is often switched on as a default hard setting (A basic customer expectation!.) so a device can be discoverable and thus should be maintained as a factory default on most devices as indicated as part of the command definition within the Core Specification. Again may be it requires that explicit clarification what are hard and soft values. "SetSystemFactoryDefault". This operation reloads parameters of a device to their factory default values. The device shall support hard and soft factory default through the SetSystemFactoryDefault command. |
@kieran242 Accept apologies if my comment sounded a bit rude. Though I have no objection in seeking inputs from GRSE, I have seen from my earlier interactions they might come back to say 'What's WG opinion on this?' Anyways we can bring this topic to discussion to both tables.
From the same section you quoted in core spec 8.3.8 SetSystemFactoryDefault, please find below text
Given that ONVIF is gravitating towards cloud profile and pretty much the whole onboarding sequence falls into the vendor purview, we should be open to identifying these grey areas to make sure ONVIF doesn't stretch into vendor domain. |
Hello! The test was developed by Testing WG long ago, not by the test tool vendor. So it was the interpretation of specification from ONVIF. In general my understanding is the following. According to section 7.2 Modes of operation: It means default state: discoverable mode. According section 8.3.8 SetSystemFactoryDefault: The scope of the soft reset is not defined clearly. But for my interpretation device parameters shall behave according on one of the following scenario:
So device suppose to be discoverable if it was discoverable before soft reset. And even if DTT currently do not test hard reset due to inability to do this without manual action (there was such test before with manual actions). Camara shall support this as required by putting camera to discoverable mode. If it does not happened device probably could pass DTT, but will not be conformant. Make sure that device is conformant is also Device vendor responsibility. See ONVIF Conformance Process Specification, 4.1 Role and responsibility: I would suggest to change ONVIF Core specification so future profiles could go without such requirements. But for existing profiles test shall stay as is, because profiles have link to exact ONVIF specification version. From DTT point of view we could keep the test running only for devices that supports old profiles. If changes to be done without ONVIF Specification update then we would like to have formal approval from TTWG to incorporate changes. Hope this feedback will help you. |
@bsriramprasad, If any device vendor wishes to disable discovery by default and encounters issues with the conformance tool, they can consider making the discovery mode reset only during a hard factory reset and not during a soft factory reset? This approach may not affect the conformance testing. |
If members are strongly against any update to spec, this is an acceptable and only workaround as we see. |
Background/Context
Device vendors communicate with integrator via 'Interface guide' with below information
If ONVIF is not enabled by default, the test operator does same steps as in interface guide to setup the device before conformance process is started in DTT.
Main issue comes with the requirement below
Ref: https://www.onvif.org/specs/core/ONVIF-Core-Specification.pdf, Section 7.2
Problem Scenario
For such a device setup/scenario, DTT test DEVICE-3-1-7 : SYSTEM COMMAND FACTORY DEFAULT SOFT does
But SetSystemFactoryDefault operation clears away all configs except IP settings and hence step 2 expecting the device to be discoverable (the setting operator made before conformance test start) seems to device default behavior as discoverable, which is again vendor/implementation dependent (some devices may be discoverable after soft reset and some may be not)
Workaround - 1
Modify test so that test doesn't fail even if device is NOT discoverable after soft reset
Workaround - 2
Additional Note
The text was updated successfully, but these errors were encountered: