Endpoint /ontologies_full is showing private ontologies

[imadbourouche]

Description

The endpoint /ontologies_full is showing private ontologies

Test in : https://data.agroportal.lirmm.fr/ontologies_full?display=viewingRestriction&display_links=false&display_context=false

Screenshot

[syphax-bouazzouni]

Can you reproduce it in bioportal ?

[imadbourouche]

https://data.agroportal.lirmm.fr/ontologies_full?display=viewingRestriction&display_links=false&display_context=false

Yes @alexskr

[alexskr]

/submissions has the same issue. See ncbo#76

[jonquet]

This might not necessarily be a problem. This endpoint is not visible, not documented, available only in the open code and now mentionned in this issue.

/ontologies_full return more information than /ontologies

https://data.agroportal.lirmm.fr/ontologies_full?&display_links=false&display_context=false

https://data.agroportal.lirmm.fr/ontologies?&display_links=false&display_context=false

Before taking a decision we need a listing of where this endpoint is being used in the code. Which views?

[syphax-bouazzouni]

@jonquet it used no where in the UI

[imadbourouche]

@jonquet it's used no where also in the api, it's just declared as route to display ontologies + submissions + metrics.

[syphax-bouazzouni]

by the way @imadbourouche , the MOD API endpoint /artefacts/{artefactID} will follow the same idea as that /ontologyfull

[imadbourouche]

@jonquet what we do for this route ? no one is using it so i suggest we don't show it until we see if we need it next time

[syphax-bouazzouni]

@jonquet what we do for this route ? no one is using it so i suggest we don't show it until we see if we need it next time

In favor of removing it.

[jonquet]

@mdorf @jvendetti do you have an opinion related to /ontologies_full route?
I would consider also removing it not used and not documented. But you might have more information related to the creation and use (maybe by another external tool).

[jvendetti]

@mdorf implemented that endpoint at the request of the CEDAR team at Stanford to address performance issues they were having with making multiple calls to multiple endpoints to collect certain data necessary for their application. Misha can correct me if I'm wrong, but I don't believe we have any intention of removing this endpoint from our codebase.

[jonquet]

Thanks for the historical note.
It makes sense to have some custom endpoints for important external client (different than the UI).

Is that ok for this endpoint to be updated (to not return private ontologies as the other ones in the API) then @mdorf could you add it to the public documentation (semi-generated).