Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'softsim' binary only built from autotools, not from cmake #1

Closed
laf0rge opened this issue Feb 20, 2024 · 1 comment · Fixed by #7
Closed

'softsim' binary only built from autotools, not from cmake #1

laf0rge opened this issue Feb 20, 2024 · 1 comment · Fixed by #7
Assignees

Comments

@laf0rge
Copy link
Collaborator

laf0rge commented Feb 20, 2024

Hi!

I just tried building using cmake, and it seems in this case only the library is built, but not the 'main' executable (for use with vpcd). Is that intentional? When building with autotools it is built.

In general, it's probably a valid question whether it makes sense to maintain support for two different build systems. Maintaining two means extra effort, and has the risk of inconsistency (as we see here).

I'm not sure what kind of internal discussions you may have had, I just wanted to share my view. In my opinion, it would be fine to remove the autotools support and only support cmake - but then add the main softsim binary to cmake.

@benjaminbruun
Copy link
Collaborator

Very valid point. We will re-visit the top internally.

For now, we have only been met with requests for the project builds to be build as a library and not its main executeable.
But you are right, it just showcase the drawbacks of two build configuration systems... Since we forgot to have a build option for the main SoftSIM binary in CMake.

@benjaminbruun benjaminbruun self-assigned this Feb 21, 2024
@benjaminbruun benjaminbruun linked a pull request Jun 4, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants