Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a "None" option for board label lettering #2804

Conversation

andywng
Copy link

@andywng andywng commented Aug 31, 2024

Fixes #2802

Proposed Changes

  • Add a None option for board label lettering. This provides the option of a cleaner looking board.

Copy link

github-actions bot commented Aug 31, 2024

Uffizzi Preview deployment-55777 was deleted.

@andywng
Copy link
Author

andywng commented Aug 31, 2024

online-go/goban#174 in the goban repo has to go in before this change will work. Please review that PR first.

@benjaminpjones
Copy link
Contributor

Should this "None" option also hide the "Toggle Coordinates" button in the game dock?

https://github.com/online-go/online-go.com/blob/2282ff03ee06dd78e3b170ea541f4ea351ce15f7/src/views/Game/GameDock.tsx#L372-376

@anoek
Copy link
Member

anoek commented Aug 31, 2024

This seems redundant with the None option in Board label positioning, which turns off the board labels

image

@BHydden
Copy link
Collaborator

BHydden commented Sep 1, 2024

None option in Board label positioning

I think with the OGS settings cockpit meme, none of us knew of this until now 😅 I will mention it in the relevant forum thread. As you say, this probably resolves the issue

@BHydden
Copy link
Collaborator

BHydden commented Sep 1, 2024

An argument could be made though that it is a valid option for both menus, however ideally toggling one should toggle both so that you don't have the situation of one blocking the other.

Where do you want to see board coords? Nowhere.
As well as
What style of board coods do you want? None.

@anoek
Copy link
Member

anoek commented Sep 1, 2024

Yeah, generally speaking two places to control the same thing isn't a great user experience. Generally speaking, just pick one, and since we already have one, I'm not sure it makes sense to add another one.

If there y'all feel strongly that this menu should have it I would second the need to have the "None" status linked with the position control so that they are either both None or both not None, but never just one.

@anoek
Copy link
Member

anoek commented Sep 4, 2024

Closing as resolved with the board label position None option

@anoek anoek closed this Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

relocate global toggle for coordinatea
5 participants