From 3ca636a9dd0f761f90498afb69ba1dee86edfbe5 Mon Sep 17 00:00:00 2001 From: aw539 Date: Sat, 31 Aug 2024 14:12:03 -0400 Subject: [PATCH] added "none" as a possible return value of getCoordinateDisplaySystem, added handling of none value --- src/Goban/CanvasRenderer.ts | 4 ++++ src/Goban/InteractiveBase.ts | 2 +- src/Goban/callbacks.ts | 2 +- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/Goban/CanvasRenderer.ts b/src/Goban/CanvasRenderer.ts index 2d3d1ca0..76e92727 100644 --- a/src/Goban/CanvasRenderer.ts +++ b/src/Goban/CanvasRenderer.ts @@ -2822,6 +2822,8 @@ export class GobanCanvas extends Goban implements GobanCanvasInterface { place("" + (c + 1), x, y); } break; + case "none": + break; } }; @@ -2878,6 +2880,8 @@ export class GobanCanvas extends Goban implements GobanCanvasInterface { v_place(chinese_japanese_numbers[c], x, y); } break; + case "none": + break; } }; diff --git a/src/Goban/InteractiveBase.ts b/src/Goban/InteractiveBase.ts index ef64ff47..d5aa37e8 100644 --- a/src/Goban/InteractiveBase.ts +++ b/src/Goban/InteractiveBase.ts @@ -464,7 +464,7 @@ export abstract class GobanInteractive extends GobanBase { return ret; } - protected getCoordinateDisplaySystem(): "A1" | "1-1" { + protected getCoordinateDisplaySystem(): "A1" | "1-1" | "none" { if (callbacks.getCoordinateDisplaySystem) { return callbacks.getCoordinateDisplaySystem(); } diff --git a/src/Goban/callbacks.ts b/src/Goban/callbacks.ts index b570d264..70814f05 100644 --- a/src/Goban/callbacks.ts +++ b/src/Goban/callbacks.ts @@ -19,7 +19,7 @@ import { GobanSelectedThemes } from "./Goban"; export interface GobanCallbacks { defaultConfig?: () => any; - getCoordinateDisplaySystem?: () => "A1" | "1-1"; + getCoordinateDisplaySystem?: () => "A1" | "1-1" | "none"; isAnalysisDisabled?: (goban: GobanBase, perGameSettingAppliesToNonPlayers: boolean) => boolean; getClockDrift?: () => number;