Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VS Extension "Local History" fails to install #3388

Open
StephanRoemer opened this issue Apr 9, 2021 · 2 comments
Open

VS Extension "Local History" fails to install #3388

StephanRoemer opened this issue Apr 9, 2021 · 2 comments
Labels
A-extension Area: Extension/plugin integration, vscode or VimL bug Something isn't working

Comments

@StephanRoemer
Copy link

StephanRoemer commented Apr 9, 2021 •
edited
Loading

After installing the VS extension "Local History", Onivim can't locate it:

Bildschirmfoto 2021-04-09 um 11 23 11
@bryphe bryphe added A-extension Area: Extension/plugin integration, vscode or VimL bug Something isn't working labels Apr 9, 2021
@bryphe
Copy link
Member

bryphe commented Apr 9, 2021

Thanks for logging, @StephanRoemer

I have a fix for the installation issue here #3394 - however, this extension uses tree views (need #3126 for that work completely). It seems like it backs up the files in the .history folder, though, at the moment.

@StephanRoemer
Copy link
Author

StephanRoemer commented Apr 9, 2021 •
edited
Loading

Ah yeah, now that you mention it...! That also explains why "Comment Anchors" is not working. It also makes use of the Tree View / Sidebar.
Bildschirmfoto 2021-04-10 um 00 14 26

bryphe added a commit that referenced this issue Apr 10, 2021
@bryphe
fix(extensions/#3388): Local history extension doesn't install (#3394)
65c7ab2 
__Issue:__ The local history extension fails to install with the error "Unable to locate extension"

__Defect:__ There is a failure parsing the extension manifest,  with these command json expressions:
```
            {
                "command": "treeLocalHistory.refresh",
                "title": "Refresh",
                "when": false,
                "icon": "$(refresh)"
            },
```

Our `"when"` expression parser only handles strings, not booleans.

__Fix:__ Extend our parser to handle booleans as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-extension Area: Extension/plugin integration, vscode or VimL bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bryphe @StephanRoemer