[Access] Add arguments getter for data providers #6873
+52
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From now on, we use only 1 id in request/response messages. This id is called `subscription_id`. A client may provide `subscription_id` in `subscribe` request. If client does not provide it, we generate it ourselves. Clients that use browsers or other async environemnts may use `subscription_id` to correlate response messages with the request ones. `subscription_id` is used in all messages related to subscription. I also remove `success` field from response. We include `subscription_id` field in a resposne in case of OK response. In case of error response, we include `error` field.
…ssageResponse with Arguments, updated unit tests
UlyanaAndrukhiv
requested review from
Guitarheroua,
AndriiDiachuk,
peterargue and
illia-malachyn
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6873 +/- ##
==========================================
+ Coverage 41.08% 44.49% +3.41%
==========================================
Files 2121 1117 -1004
Lines 185905 114370 -71535
==========================================
- Hits 76373 50887 -25486
+ Misses 103118 59177 -43941
+ Partials 6414 4306 -2108
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
….com:The-K-R-O-K/flow-go into UlianaAndrukhiv/6865-data-provider-arguments
…of github.com:The-K-R-O-K/flow-go into UlianaAndrukhiv/6865-data-provider-arguments
…age-id to avoid pendency on it
|
LGTM |
….com:The-K-R-O-K/flow-go into UlianaAndrukhiv/6865-data-provider-arguments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #6865
Context
This pull request adds a method
Argumentsto the data providers, allowing retrieval of stored initial request arguments. This method used by thelistOfSubscriptionto fill theArgumentsfield forListSubscriptionsMessageResponse.