Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Consensus Matching Engine: engine.Unit -> ComponentManager #6854

Open
jordanschalm opened this issue Jan 7, 2025 · 0 comments
Open

Refactor Consensus Matching Engine: engine.Unit -> ComponentManager #6854

jordanschalm opened this issue Jan 7, 2025 · 0 comments
Assignees
@jordanschalm @tim-barry
Labels
Protocol Team: Issues assigned to the Protocol Pillar. Tech Debt

Comments

@jordanschalm
Copy link
Member

jordanschalm commented Jan 7, 2025 •
edited by tim-barry
Loading

Problem Definition

The Matching Engine should be updated to clarify its interface, including blocking versus non-blocking calls, error handling and propagation, documentation, and its scope of operation (internal messages vs network messages). Refer to comments on #6747 for additional details.

Proposed Solution

  • Refactor to replace the deprecated engine.Unit with ComponentManager.
  • Update unit tests to accurately verify the functionality and boundaries of the Matching Engine.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jordanschalm jordanschalm

@tim-barry tim-barry

Labels
Protocol Team: Issues assigned to the Protocol Pillar. Tech Debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jordanschalm @tim-barry