perf

cmd/goforward/root.go

@@ -63,7 +63,7 @@ var rootCmd = &cobra.Command{
 		if err != nil {
 			return err
 		}
-		err = runServer(*cfg)
+		err = runServer(cfg)
 		if err != nil {
 			fmt.Println(err)
 			os.Exit(1)
@@ -79,7 +79,7 @@ func Execute() {
 	}
 }
 
-func runServer(cfg config.Config) (err error) {
+func runServer(cfg *config.Config) (err error) {
 	log.InitLog(cfg.LogWay, cfg.LogFile, cfg.LogLevel, cfg.LogMaxDays, cfg.DisableLogColor)
 
 	if cfgFile != "" {

internal/api/forward/add.go

@@ -16,7 +16,7 @@ type AddForwardRequest struct {
 func Add(c *gin.Context) {
 	var request AddForwardRequest
 	c.ShouldBindJSON(&request)
-	if len(request.ForwardLink) == 0 {
+	if request.ForwardLink == "" {
 		c.JSON(400, gin.H{"error": "forward link is empty"})
 		return
 	}

internal/api/forward/del.go

@@ -11,7 +11,7 @@ import (
 func Del(c *gin.Context) {
 	m := manager.GetInstance()
 	listenAddr := c.Param("listen_addr")
-	if len(listenAddr) == 0 {
+	if listenAddr == "" {
 		c.JSON(400, gin.H{"error": "listen_addr is empty"})
 		return
 	}

internal/constants/version.go

@@ -1,3 +1,3 @@
 package constants
 
-const VERSION = "0.1.0"
+const VERSION = "0.1.1"

internal/manager/manager.go

@@ -11,10 +11,10 @@ type Manager struct {
 	ForwardMap map[string]*forward.Forward
 }
 
-func (m Manager) AddForward(ForwardLinks models.ForwardLinks, override bool) error {
-	for _, i := range ForwardLinks {
+func (m Manager) AddForward(forwardLinks models.ForwardLinks, override bool) error {
+	for _, i := range forwardLinks {
 		key := i.ListenAddr.String()
-		forward := forward.NewForward(i)
+		forwardIns := forward.NewForward(i)
 		if f, ok := m.ForwardMap[key]; ok {
 			if override {
 				err := f.Stop()
@@ -25,11 +25,11 @@ func (m Manager) AddForward(ForwardLinks models.ForwardLinks, override bool) err
 				return fmt.Errorf("forward %s already exists, if want to override, set param override to true", key)
 			}
 		}
-		err := forward.Start()
+		err := forwardIns.Start()
 		if err != nil {
 			return fmt.Errorf("forward %s start err: %s", key, err)
 		}
-		m.ForwardMap[key] = forward
+		m.ForwardMap[key] = forwardIns
 	}
 	return nil
 }

internal/pkg/forward/forward.go

@@ -111,9 +111,9 @@ func (f *Forward) MarshalJSON() ([]byte, error) {
 	})
 }
 
-func NewForward(ForwardLink models.ForwardLink) *Forward {
+func NewForward(forwardLink models.ForwardLink) *Forward {
 	return &Forward{
-		Link: ForwardLink,
+		Link: forwardLink,
 		quit: make(chan bool, 1),
 	}
 }

internal/pkg/log/log.go

@@ -16,22 +16,22 @@ func init() {
 	Log.SetLogFuncCallDepth(Log.GetLogFuncCallDepth() + 1)
 }
 
-func InitLog(logWay string, logFile string, logLevel string, maxdays int64, disableLogColor bool) {
+func InitLog(logWay, logFile, logLevel string, maxdays int64, disableLogColor bool) {
 	SetLogFile(logWay, logFile, maxdays, disableLogColor)
 	SetLogLevel(logLevel)
 }
 
 // SetLogFile to configure log params
 // logWay: file or console
-func SetLogFile(logWay string, logFile string, maxdays int64, disableLogColor bool) {
+func SetLogFile(logWay, logFile string, maxdays int64, disableLogColor bool) {
 	if logWay == "console" {
 		params := ""
 		if disableLogColor {
 			params = fmt.Sprintf(`{"color": false}`)
 		}
 		Log.SetLogger("console", params)
 	} else {
-		params := fmt.Sprintf(`{"filename": "%s", "maxdays": %d}`, logFile, maxdays)
+		params := fmt.Sprintf(`{"filename": "%q", "maxdays": %d}`, logFile, maxdays)
 		Log.SetLogger("file", params)
 	}
 }