Skip to content
This repository has been archived by the owner on Jan 18, 2023. It is now read-only.

Release v1.2.0 #290

Closed
wants to merge 16 commits into from
Closed

Release v1.2.0 #290

wants to merge 16 commits into from

Conversation

Azoraqua
Copy link
Contributor

@Azoraqua Azoraqua commented Sep 4, 2022

No description provided.

@Azoraqua Azoraqua added this to the Release 2 milestone Sep 4, 2022
@Azoraqua Azoraqua linked an issue Sep 4, 2022 that may be closed by this pull request
Update the project. #285
Open
4 tasks
@Azoraqua Azoraqua added enhancement New feature or request v2 refactor dependencies Pull requests that update a dependency file labels Sep 4, 2022
This was linked to issues Sep 4, 2022
Add TypeScript (TS) #286
Closed
Replace Create React App (CRA) with Create Vite App (Vite) #287
Closed
Use an UI toolkit (To be discussed, defaulting to MaterialUI) #288
Closed
Update additional dependencies and remove unneccessary ones. #289
Closed
aayushchugh
aayushchugh approved these changes Sep 4, 2022
View reviewed changes
Copy link
Contributor

@aayushchugh aayushchugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

I don't have courage to review these many changes so I will just approve them

@haIIux
Copy link

haIIux commented Sep 4, 2022

It's likely not good practice to blindly approve without actually taking a look to review and provide feedback if needed.

@aayushchugh
Copy link
Contributor

aayushchugh commented Sep 4, 2022 •
edited
Loading

It's likely not good practice to blindly approve without actually taking a look to review and provide feedback if needed.

I actually saw the code in vscode he just created backup of src and public and initialized vite
just did that for fun

@aayushchugh aayushchugh self-requested a review September 4, 2022 18:44
Azoraqua
Azoraqua commented Sep 7, 2022
View reviewed changes
Copy link
Contributor Author

@Azoraqua Azoraqua left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I suggest to remove .vscode and put it in a .gitignore.

Beyond that, I like to call the folders like:

  • components
  • hooks
  • models
  • reducers
  • routers
  • contexts
  • helpers / utils
  • ...

@0xLeif 0xLeif closed this Oct 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@0xLeif 0xLeif Awaiting requested review from 0xLeif

@haIIux haIIux Awaiting requested review from haIIux

@aayushchugh aayushchugh Awaiting requested review from aayushchugh

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request refactor v2
Projects
None yet
Milestone
Release 2
4 participants
@Azoraqua @haIIux @aayushchugh @0xLeif