This repository has been archived by the owner on Aug 26, 2022. It is now read-only.
Create edit view #13
Open
Create edit view #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
Fabricevladimir
approved these changes
Apr 11, 2020
| ************************************/ | ||
|
|
||
| return ( | ||
| <textarea style={{height: 'inherit'}} {...rest} onChange={onValueChange}></textarea> |
There was a problem hiding this comment.
Any reason why you're setting the styling here as opposed to CSS?
There was a problem hiding this comment.
The height of the 'EditMode' will be determined by the user passing down a height. This text area will calculate the height based off that passed in height (will be shorter at some point). Since it's dynamic i should be doing this styling inline.
Also from what i've seen these npm packages don't usually use style sheets. Need to determine the best way to do this. Might make the most sense to keep all functionality on a component since it's the one thing being imported
0xLeif
approved these changes
Apr 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.