From 0f285b0e0c7fe87c250eed4c8b19e471b3119835 Mon Sep 17 00:00:00 2001
From: Benn Simon <botieno@ona.io>
Date: Wed, 4 Dec 2024 16:29:00 +0300
Subject: [PATCH] add unit and default_value config (#32)

---
 storage.tf   | 11 +++++------
 variables.tf | 12 ++++++++++++
 2 files changed, 17 insertions(+), 6 deletions(-)

diff --git a/storage.tf b/storage.tf
index d9510b6..455ad49 100644
--- a/storage.tf
+++ b/storage.tf
@@ -310,9 +310,11 @@ resource "aws_cloudwatch_log_metric_filter" "slow_query_metric_filter" {
   name           = var.postgresql_slow_query_metric_filter_name
   pattern        = join("?", var.postgresql_slow_query_pattern)
   metric_transformation {
-    name      = var.postgresql_slow_query_metric_filter_name
-    namespace = var.postgresql_slow_query_metric_namespace
-    value     = var.postgresql_slow_query_metric_value
+    name          = var.postgresql_slow_query_metric_filter_name
+    namespace     = var.postgresql_slow_query_metric_namespace
+    value         = var.postgresql_slow_query_metric_value
+    unit          = var.postgresql_slow_query_metric_unit
+    default_value = var.postgresql_slow_query_metric_default_value
   }
 }
 
@@ -341,7 +343,4 @@ resource "aws_cloudwatch_metric_alarm" "slow_query_metric_alarm" {
     severity          = var.postgresql_slow_query_severity
   }
 
-  dimensions = {
-    DBInstanceIdentifier = (length(var.postgresql_source_snapshot_identifier) == 0 && var.postgresql_replicate_source_db == null) ? aws_db_instance.blank-database[0].identifier : var.postgresql_replicate_source_db != null ? aws_db_instance.replica-database[0].identifier : aws_db_instance.from-snapshot[0].identifier
-  }
 }
diff --git a/variables.tf b/variables.tf
index eef1872..9c05a91 100644
--- a/variables.tf
+++ b/variables.tf
@@ -281,6 +281,18 @@ variable "postgresql_slow_query_metric_value" {
   default     = 1
 }
 
+variable "postgresql_slow_query_metric_unit" {
+  type        = string
+  description = "Unit of measurement"
+  default     = "Count"
+}
+
+variable "postgresql_slow_query_metric_default_value" {
+  type        = number
+  description = "The default value is published to the metric when the pattern does not match. If you leave this blank, no value is published when there is no match"
+  default     = 0
+}
+
 variable "postgresql_slow_query_pattern" {
   type        = list(string)
   description = "The terms or pattern to match in your log events to create metrics"