Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use AWS_DEFAULT_REGION by default #28

Merged
merged 1 commit into from
Aug 22, 2024
Merged

feat: use AWS_DEFAULT_REGION by default #28

merged 1 commit into from
Aug 22, 2024

Conversation

ethanholz
Copy link
Contributor

Closes #26.

This leans on boto3 using AWS_DEFAULT_REGION to use the default role region but overrides if it is provided.

@ethanholz ethanholz requested a review from dwhswenson August 22, 2024 19:06
@ethanholz ethanholz self-assigned this Aug 22, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.80%. Comparing base (c590fbd) to head (8c278c2).
Report is 5 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #28      +/-   ##
==========================================
+ Coverage   94.70%   94.80%   +0.10%     
==========================================
  Files           3        3              
  Lines         302      308       +6     
==========================================
+ Hits          286      292       +6     
  Misses         16       16
Flag Coverage Δ
unittests 94.80% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dwhswenson
dwhswenson approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@dwhswenson dwhswenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor optional change. I'm not sure that it matters, but it is probably better practice to make sure you undo any changes to globals that you make during a test.

@ethanholz ethanholz merged commit 6bef356 into omsf-eco-infra:main Aug 22, 2024
5 checks passed
@ethanholz ethanholz deleted the feat/region branch August 22, 2024 19:53
ethanholz added a commit that referenced this pull request Aug 22, 2024
@ethanholz
fix: Revert "Merge pull request #28 from ethanholz/feat/region"
35cb7d5 
This reverts commit 6bef356, reversing
changes made to a7cd625. This merge
proved to be very buggy after testing with `openmm-gpu-test`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwhswenson dwhswenson dwhswenson approved these changes

Assignees

@ethanholz ethanholz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Utilize AWS_REGION and AWS_DEFAULT_REGION environment variables when provisioning
2 participants
@ethanholz @dwhswenson