-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Semantics - Removal of CSS #71
Comments
* Add screen reader accessible text label. * Create aria-hidden span for icon pseudo element. * Also revises translate plugin calls.
Copying my response from the equivalent issue in cozy.
The search toggle button doesn't have a visible text label when you remove styles. While it did have an aria-label, I opted to give it a text label only viewable to screen readers when CSS is on. Should be ready for testing. |
From my perspective testing with VoiceOver on Chrome, the toggle search button is still discernible to the screenreader when CSS is off. Additionally, when CSS is on, there is a focus order issue here. Once a user toggles the search bar open, tabbing does not bring focus to the search bar and instead skips down to the nav menu. |
When removing the CSS from the page, a smaller, non-functional button called "toggle search" appears below the search bar. Additionally, if there is a carousel it loses all functionality.
The text was updated successfully, but these errors were encountered: