Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should PlanePoint be changed to PlanePoint2D? #421

Open
scuniff opened this issue Jan 2, 2024 · 0 comments
Open

Should PlanePoint be changed to PlanePoint2D? #421

scuniff opened this issue Jan 2, 2024 · 0 comments

Comments

@scuniff
Copy link

scuniff commented Jan 2, 2024

https://github.com/ome/omero-insight/blob/4e8d0754713b0a3c74908b4ebaa9ebae4e378a14/src/main/java/org/openmicroscopy/shoola/util/math/geom2D/PlanePoint2D.java#L232C5-L237C6

Referring to this code snippet:

public boolean equals(Object o)
{
	if (o == null || (!(o instanceof PlanePoint))) return false;
	 PlanePoint other = (PlanePoint) o;
     return (x1 == other.x1 && x2 == other.x2);  
}

Should the 3 references to PlanePoint actually be PlanePoint2D?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant