Skip to content

Commit fc5448d

Browse files
committed
Fix unnecessary type hint
1 parent 0f01e24 commit fc5448d

File tree

4 files changed

+35
-38
lines changed

4 files changed

+35
-38
lines changed

freckle_client/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
# -*- coding: utf-8 -*-
22
"""Freckle client package."""
3-
__version__ = "1.0.2" # pragma: no cover
3+
__version__ = "1.0.3" # pragma: no cover

noko_client/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
# -*- coding: utf-8 -*-
22
"""Noko client package."""
3-
__version__ = "1.0.2" # pragma: no cover
3+
__version__ = "1.0.3" # pragma: no cover

noko_client/client.py

Lines changed: 31 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ class NokoClient(BaseClient):
5555

5656
# Entry related methods
5757

58-
def list_entries(self, **kwargs: dict) -> list[dict]:
58+
def list_entries(self, **kwargs) -> list[dict]:
5959
"""List all entries.
6060
6161
By default, retrieves all entries. The entries to retrieve can be filtered based on accepted Keyword Arguments.
@@ -103,7 +103,7 @@ def get_single_entry(self, entry_id: str | int) -> list[dict]:
103103
"""
104104
return self.fetch_json(f"entries/{entry_id}", http_method="GET")
105105

106-
def create_entry(self, **kwargs: dict) -> list[dict]:
106+
def create_entry(self, **kwargs) -> list[dict]:
107107
"""Create new entry in Noko.
108108
109109
Keyword Args:
@@ -127,7 +127,7 @@ def create_entry(self, **kwargs: dict) -> list[dict]:
127127
data = CreateNokoEntryParameters(**kwargs).model_dump()
128128
return self.fetch_json("entries", post_args=data, http_method="POST")
129129

130-
def edit_entry(self, entry_id: int | str, **kwargs: dict) -> list[dict]:
130+
def edit_entry(self, entry_id: int | str, **kwargs) -> list[dict]:
131131
"""Edit an existing entry.
132132
133133
Args:
@@ -252,7 +252,7 @@ def delete_entry(self, entry_id: str | int) -> None:
252252

253253
# Tag related methods
254254

255-
def list_tags(self, **kwargs: dict) -> list[dict]:
255+
def list_tags(self, **kwargs) -> list[dict]:
256256
"""List all tags.
257257
258258
By default, retrieves all tags. The tags to retrieve can be filtered based on accepted Keyword Arguments.
@@ -292,7 +292,7 @@ def get_single_tag(self, tag_id: int | str) -> list[dict]:
292292
"""
293293
return self.fetch_json(f"tags/{tag_id}", http_method="GET")
294294

295-
def get_all_entries_for_tag(self, tag_id: str | int, **kwargs: dict) -> list[dict]:
295+
def get_all_entries_for_tag(self, tag_id: str | int, **kwargs) -> list[dict]:
296296
"""Retrieve all time entries associated with a tag.
297297
298298
Results can be filtered using the same keyword arguments as the ones used for the list entries endpoint.
@@ -408,7 +408,7 @@ def delete_tags(self, tag_ids: list[str | int]) -> None:
408408

409409
# Project related methods
410410

411-
def list_projects(self, **kwargs: dict) -> list[dict]:
411+
def list_projects(self, **kwargs) -> list[dict]:
412412
"""List all projects from Noko.
413413
414414
By default, retrieves all projects. Projects to retrieve can be filtered based on accepted Keyword Arguments.
@@ -439,7 +439,7 @@ def get_single_project(self, project_id: str | int) -> list[dict]:
439439
"""
440440
return self.fetch_json(f"projects/{project_id}", http_method="GET")
441441

442-
def create_project(self, **kwargs: dict) -> list[dict]:
442+
def create_project(self, **kwargs) -> list[dict]:
443443
"""Create new project in Noko.
444444
445445
Keyword Args:
@@ -459,7 +459,7 @@ def create_project(self, **kwargs: dict) -> list[dict]:
459459
return self.fetch_json("projects", post_args=data, http_method="POST")
460460

461461
def get_all_entries_for_project(
462-
self, project_id: str | int, **kwargs: dict
462+
self, project_id: str | int, **kwargs
463463
) -> list[dict]:
464464
"""Retrieve all time entries associated with a project.
465465
@@ -503,9 +503,7 @@ def get_all_entries_for_project(
503503
f"projects/{project_id}/entries", query_params=params, http_method="GET"
504504
)
505505

506-
def get_expenses_for_project(
507-
self, project_id: str | int, **kwargs: dict
508-
) -> list[dict]:
506+
def get_expenses_for_project(self, project_id: str | int, **kwargs) -> list[dict]:
509507
"""Get all expenses associated with a project.
510508
511509
Results can be filtered using the same keyword arguments as the ones used for the list expenses endpoint.
@@ -541,7 +539,7 @@ def get_expenses_for_project(
541539
f"projects/{project_id}/expenses", query_params=params, http_method="GET"
542540
)
543541

544-
def edit_project(self, project_id: str | int, **kwargs: dict) -> list[dict]:
542+
def edit_project(self, project_id: str | int, **kwargs) -> list[dict]:
545543
"""Edit an existing project.
546544
547545
Args:
@@ -671,7 +669,7 @@ def delete_projects(self, project_ids: list[int | str]) -> None:
671669

672670
# Project group related methods
673671

674-
def list_project_groups(self, **kwargs: dict) -> list[dict]:
672+
def list_project_groups(self, **kwargs) -> list[dict]:
675673
"""List all project groups from Noko.
676674
677675
Keyword Args:
@@ -685,7 +683,7 @@ def list_project_groups(self, **kwargs: dict) -> list[dict]:
685683
params = GetNokoProjectGroupsParameters(**kwargs).model_dump()
686684
return self.fetch_json("project_groups", query_params=params, http_method="GET")
687685

688-
def create_project_group(self, **kwargs: dict) -> list[dict]:
686+
def create_project_group(self, **kwargs) -> list[dict]:
689687
"""Create a new project group.
690688
691689
Keyword Args:
@@ -728,7 +726,7 @@ def edit_project_group(self, project_group_id: str | int, name: str) -> list[dic
728726
)
729727

730728
def get_all_entries_for_project_in_project_group(
731-
self, project_group_id: str | int, **kwargs: dict
729+
self, project_group_id: str | int, **kwargs
732730
) -> list[dict]:
733731
"""Retrieve all time entries associated with the projects in a project group.
734732
@@ -775,7 +773,7 @@ def get_all_entries_for_project_in_project_group(
775773
)
776774

777775
def get_all_projects_in_project_group(
778-
self, project_group_id: str | int, **kwargs: dict
776+
self, project_group_id: str | int, **kwargs
779777
) -> list[dict]:
780778
"""Retrieve all projects in a project group.
781779
@@ -876,7 +874,7 @@ def delete_project_group(self, project_group_id: str | int) -> None:
876874

877875
# Invoice related methods
878876

879-
def list_invoices(self, **kwargs: dict) -> list[dict]:
877+
def list_invoices(self, **kwargs) -> list[dict]:
880878
"""List Noko invoices.
881879
882880
Keyword Args:
@@ -953,7 +951,7 @@ def get_single_invoice(self, invoice_id: str | int) -> list[dict]:
953951
"""
954952
return self.fetch_json(f"invoices/{invoice_id}", http_method="GET")
955953

956-
def create_invoice(self, **kwargs: dict) -> list[dict]:
954+
def create_invoice(self, **kwargs) -> list[dict]:
957955
"""Create a new invoice in Noko.
958956
959957
For additional information on options available for rate_calculation, taxes and customisation, refer to the
@@ -1004,7 +1002,7 @@ def create_invoice(self, **kwargs: dict) -> list[dict]:
10041002
data = CreateNokoInvoiceParameters(**kwargs).model_dump()
10051003
return self.fetch_json("invoices", post_args=data, http_method="POST")
10061004

1007-
def edit_invoice(self, invoice_id: str | int, **kwargs: dict) -> list[dict]:
1005+
def edit_invoice(self, invoice_id: str | int, **kwargs) -> list[dict]:
10081006
"""Edit a Noko invoice.
10091007
10101008
Args:
@@ -1079,7 +1077,7 @@ def mark_invoice_as_unpaid(self, invoice_id: str | int) -> None:
10791077
"""
10801078
self.fetch_json(f"invoices/{invoice_id}/unpaid", http_method="PUT")
10811079

1082-
def get_invoice_entries(self, invoice_id: str | int, **kwargs: dict) -> list[dict]:
1080+
def get_invoice_entries(self, invoice_id: str | int, **kwargs) -> list[dict]:
10831081
"""Retrieve all time entries associated with an invoice.
10841082
10851083
Results can be filtered using the same keyword arguments as the ones used for the list entries endpoint.
@@ -1122,7 +1120,7 @@ def get_invoice_entries(self, invoice_id: str | int, **kwargs: dict) -> list[dic
11221120
f"invoices/{invoice_id}/entries", query_params=params, http_method="GET"
11231121
)
11241122

1125-
def get_invoice_expenses(self, invoice_id: str | int, **kwargs: dict) -> list[dict]:
1123+
def get_invoice_expenses(self, invoice_id: str | int, **kwargs) -> list[dict]:
11261124
"""Retrieve all expenses associated with an invoice.
11271125
11281126
Results can be filtered using the same keyword arguments as the ones used for the list expenses endpoint.
@@ -1319,7 +1317,7 @@ def delete_invoice(self, invoice_id: int | str) -> None:
13191317

13201318
# Expenses related methods
13211319

1322-
def list_expenses(self, **kwargs: dict) -> list[dict]:
1320+
def list_expenses(self, **kwargs) -> list[dict]:
13231321
"""List expenses from Noko.
13241322
13251323
Keyword Args:
@@ -1358,7 +1356,7 @@ def get_single_expense(self, expense_id: str | int) -> list[dict]:
13581356
"""
13591357
return self.fetch_json(f"expenses/{expense_id}", http_method="GET")
13601358

1361-
def create_expense(self, **kwargs: dict) -> list[dict]:
1359+
def create_expense(self, **kwargs) -> list[dict]:
13621360
"""Create a new expense in Noko.
13631361
13641362
Keyword Args:
@@ -1379,7 +1377,7 @@ def create_expense(self, **kwargs: dict) -> list[dict]:
13791377
data = CreateNokoExpenseParameters(**kwargs).model_dump()
13801378
return self.fetch_json("expenses", post_args=data, http_method="POST")
13811379

1382-
def edit_expense(self, expense_id: str | int, **kwargs: dict) -> list[dict]:
1380+
def edit_expense(self, expense_id: str | int, **kwargs) -> list[dict]:
13831381
"""Edit an expense in Noko.
13841382
13851383
Args:
@@ -1427,7 +1425,7 @@ def get_account_details(self) -> list[dict]:
14271425

14281426
# User related methods
14291427

1430-
def list_users(self, **kwargs: dict) -> list[dict]:
1428+
def list_users(self, **kwargs) -> list[dict]:
14311429
"""List all Noko users in the account.
14321430
14331431
Keyword Args:
@@ -1455,7 +1453,7 @@ def get_single_user(self, user_id: int | str) -> list[dict]:
14551453
"""
14561454
return self.fetch_json(f"users/{user_id}", http_method="GET")
14571455

1458-
def get_user_entries(self, user_id: int | str, **kwargs: dict) -> list[dict]:
1456+
def get_user_entries(self, user_id: int | str, **kwargs) -> list[dict]:
14591457
"""Get all entries associated with a user.
14601458
14611459
Results can be filtered using the same keyword arguments as the ones used for the list entries endpoint.
@@ -1498,7 +1496,7 @@ def get_user_entries(self, user_id: int | str, **kwargs: dict) -> list[dict]:
14981496
f"users/{user_id}/entries", query_params=params, http_method="GET"
14991497
)
15001498

1501-
def get_user_expenses(self, user_id: str | int, **kwargs: dict) -> list[dict]:
1499+
def get_user_expenses(self, user_id: str | int, **kwargs) -> list[dict]:
15021500
"""Retrieve all expenses associated with a user.
15031501
15041502
Results can be filtered using the same keyword arguments as the ones used for the list expenses endpoint.
@@ -1534,7 +1532,7 @@ def get_user_expenses(self, user_id: str | int, **kwargs: dict) -> list[dict]:
15341532
f"users/{user_id}/expenses", query_params=params, http_method="GET"
15351533
)
15361534

1537-
def create_user(self, **kwargs: dict) -> list[dict]:
1535+
def create_user(self, **kwargs) -> list[dict]:
15381536
"""Create a new Noko user.
15391537
15401538
If your account has per-user billing, adding a new user will affect the total of your next invoice.
@@ -1552,7 +1550,7 @@ def create_user(self, **kwargs: dict) -> list[dict]:
15521550
data = CreateNokoUserParameters(**kwargs).model_dump()
15531551
return self.fetch_json("users", post_args=data, http_method="POST")
15541552

1555-
def edit_user(self, user_id: str | int, **kwargs: dict) -> list[dict]:
1553+
def edit_user(self, user_id: str | int, **kwargs) -> list[dict]:
15561554
"""Edit a Noko user's details.
15571555
15581556
Args:
@@ -1686,7 +1684,7 @@ def deactivate_user(self, user_id: str | int) -> None:
16861684

16871685
# Team related methods
16881686

1689-
def list_teams(self, **kwargs: dict) -> list[dict]:
1687+
def list_teams(self, **kwargs) -> list[dict]:
16901688
"""List all teams in Noko.
16911689
16921690
Keyword Args:
@@ -1711,7 +1709,7 @@ def get_single_team(self, team_id: str | int) -> list[dict]:
17111709
"""
17121710
return self.fetch_json(f"teams/{team_id}", http_method="GET")
17131711

1714-
def create_team(self, **kwargs: dict) -> list[dict]:
1712+
def create_team(self, **kwargs) -> list[dict]:
17151713
"""Create a new team in Noko.
17161714
17171715
Keyword Args:
@@ -1740,9 +1738,7 @@ def edit_team(self, team_id: str | int, name: str) -> list[dict]:
17401738
f"teams/{team_id}", post_args=post_args, http_method="PUT"
17411739
)
17421740

1743-
def get_entries_for_users_in_team(
1744-
self, team_id: str | int, **kwargs: dict
1745-
) -> list[dict]:
1741+
def get_entries_for_users_in_team(self, team_id: str | int, **kwargs) -> list[dict]:
17461742
"""Get all entries associated with a team.
17471743
17481744
Results can be filtered using the same keyword arguments as the ones used for the list entries endpoint.
@@ -1785,7 +1781,7 @@ def get_entries_for_users_in_team(
17851781
f"teams/{team_id}/entries", post_args=data, http_method="GET"
17861782
)
17871783

1788-
def get_users_in_team(self, team_id: str | int, **kwargs: dict) -> list[dict]:
1784+
def get_users_in_team(self, team_id: str | int, **kwargs) -> list[dict]:
17891785
"""Get all users in a team.
17901786
17911787
Results can be filtered using the same keyword arguments as the ones used for the users entries endpoint.

pyproject.toml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,15 @@ filter_files = true
44

55
[tool.flake8]
66
exclude = ["venv"]
7+
# Ignore missing type annotation on **kwargs: ANN003
78
# Ignore missing type annotation for self: ANN101
89
# Ignore missing type annotation for cls: ANN102
910
# Ignore missing type annotation for special methods (i.e. __init__): ANN204
1011
# Disable import order errors: AZ100
1112
# Ignore missing docstrings in __init__: D107
1213
# Ignore line too long errors: E501. Flake8 flags comments and docstrings, while black doesn't. Let black handle line length.
1314
# Conflicts with W504 and no longer conforms to PEP8: W503
14-
extend-ignore = ["ANN101", "ANN102", "ANN204", "AZ100", "D107", "E501", "I900", "W503"]
15+
extend-ignore = ["ANN003", "ANN101", "ANN102", "ANN204", "AZ100", "D107", "E501", "I900", "W503"]
1516
literal-inline-quotes = "double"
1617
literal-multiline-quotes = "double"
1718
known-modules=":[noko_client],python-dateutil:[dateutil]"

0 commit comments

Comments
 (0)