Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define ON/OFF in fan feature list #792

Merged
merged 5 commits into from
Oct 6, 2024
Merged

Define ON/OFF in fan feature list #792

merged 5 commits into from
Oct 6, 2024

Conversation

iprak
Copy link
Contributor

@iprak iprak commented Sep 7, 2024 •
edited
Loading

This PR in hass-core (home-assistant/core#121447) stipulates that fan entities need to set ON/OFF feature flag if on/off operation is supported (milestone 2024.8.0b0). This PR just adds those two feature values and would address #783.

https://developers.home-assistant.io/blog/2024/07/19/fan-fanentityfeatures-turn-on_off/

Closes #783

@iprak iprak changed the title Define ON/OFF in feature list Define ON/OFF in fan feature list Sep 9, 2024
@iprak
Copy link
Contributor Author

iprak commented Sep 9, 2024

@ollo69 Please review

@ollo69
Copy link
Owner

ollo69 commented Sep 16, 2024

We must change minimum required HA version to apply this CR.

@iprak
Copy link
Contributor Author

iprak commented Sep 16, 2024

We must change minimum required HA version to apply this CR.

I think you are referring to the version in hacs.json ? Should the version in requirements.txt also be updated? It currently doesn't match hacs.json

@ollo69
Copy link
Owner

ollo69 commented Sep 16, 2024

I think you are referring to the version in hacs.json ?

Everything should match the minimum required version for this change:

  • requirements.txt (homeassistant version to use)
  • requirements_test.txt (pytest-homeassistant-custom-component version)
  • hacs.json
  • const.py

Should the version in requirements.txt also be updated? It currently doesn't match hacs.json

requirements.txt contains the exact version to use with dev-container, hacs.json the minimum ha version allowed for installation. They don't match just for minor version.

Best way to make PR is using proper dev tools:

  • install docker desktop and VSCode
  • open the dev-container using VSCode
  • work on the code
  • run in dev-env to test changes

Thanks 👍

@ShantanuKhan ShantanuKhan mentioned this pull request Sep 29, 2024
Closed
@ollo69 ollo69 merged commit 0c1168e into ollo69:master Oct 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

class 'custom_components.smartthinq_sensors.fan.LGEFan' does not set FanEntityFeature.TURN_OFF or TURN_ON
2 participants
@iprak @ollo69