Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Poetry to 2.x.x or use uv #410

Open
ParthSareen opened this issue Jan 6, 2025 · 5 comments
Open

Upgrade Poetry to 2.x.x or use uv #410

ParthSareen opened this issue Jan 6, 2025 · 5 comments
Assignees

Comments

@ParthSareen
Copy link
Contributor

No description provided.

@akx
Copy link
Contributor

akx commented Jan 14, 2025

I would suggest not using Poetry at all, but e.g. uv if you really do need locking (you probably don't; libraries generally don't), and just standard PEP 517 packaging, using e.g. Hatch/Hatchling as the backend.

@ParthSareen
Copy link
Contributor Author

@akx thanks for the suggestion and I'm a fan of uv. For now, I think having locking just gives a peace of mind to ensure we don't have breaking changes from a random library. I'd rather own that responsibility than give it to the user

@akx
Copy link
Contributor

akx commented Jan 14, 2025

If dependencies are locked too strictly in the distributed package (I didn't check if that's the case for the sdist/wheel here though), it could prevent downstream users from eg. installing a security update to one of the locked deps.

@akx
Copy link
Contributor

akx commented Jan 14, 2025

I didn't check if that's the case for the sdist/wheel here though

Okay, I did check now:

$ unzip -p ollama-0.4.6-py3-none-any.whl ollama-0.4.6.dist-info/METADATA | grep Requires
Requires-Python: >=3.8,<4.0
Requires-Dist: httpx (>=0.27.0,<0.28.0)
Requires-Dist: pydantic (>=2.9.0,<3.0.0)

IOW, there are no pinned deps in the distributions other than the loose ranges specified in

httpx = "^0.27.0"
pydantic = "^2.9.0"

so there'd be no change in "owning the responsibility" there.

IOW, the requirements.txt file that is generated/checked in CI with poetry export is not used for anything that I can see. 🤷

@ParthSareen
Copy link
Contributor Author

...
IOW, the requirements.txt file that is generated/checked in CI with poetry export is not used for anything that I can see. 🤷

Hmm okay, that makes a lot of sense. I think uv makes sense here then and I prefer it anyways. Will probably bump poetry to 2.x.x for now and then move over to uv. Thanks for pointing this out :D

@ParthSareen ParthSareen changed the title Bump poetry version to 2.X.X Move build system to use uv :) Jan 20, 2025
@ParthSareen ParthSareen changed the title Move build system to use uv :) Upgrade Poetry to 2.x.x or use uv Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants