Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't swallow errors? #25

Open
hden opened this issue Oct 11, 2021 · 2 comments
Open

Don't swallow errors? #25

hden opened this issue Oct 11, 2021 · 2 comments

Comments

@hden
Copy link

hden commented Oct 11, 2021

Some system might be need to interpret the error down stream. Maybe we can propagate the errors?

https://github.com/oliyh/superlifter/blob/master/src/superlifter/core.cljc#L90-L95

@oliyh
Copy link
Owner

oliyh commented Oct 12, 2021

Hi,

Do you have a specific use-case in mind?

Thanks

@hden
Copy link
Author

hden commented Oct 12, 2021

Thanks for replying. We have a centralized error handler which translates the internal error messages to something much more user-friendly. Also, we have some data-transformation process down the promise chain (after superlifter) that might also throw errors. So it's easier for us to have a centralized error handler close to the resolver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants