Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Landing page #11

Merged
merged 6 commits into from
Jun 7, 2024
Merged

Landing page #11

merged 6 commits into from
Jun 7, 2024

Conversation

ashutoshspunyani99-tamu
Copy link
Contributor

The following changes are included in this pull request:

  1. Responsive mobile design of the mission component.
  2. Fixed the hydration and layout issues.
    Note: For the slow loading of the navbar, I found that one major issue is the large image size (4MB).

Copy link
Contributor

@SumitNalavade SumitNalavade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for digging into the cause of the slow logo loading. I think we're going to have to work with Nicolas to get smaller file sizes for image components. This applies to all image components in the project.

I'm just going to push a couple very minor changes to this pr relating to padding on some elements and spacing on the homepage.

Other than that, I think we're good to merge!

@AndrewChian2 AndrewChian2 merged commit 8286f8e into main Jun 7, 2024
@ayfatoye ayfatoye deleted the landing-page branch June 18, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Navbar 'Olivia-Kids' logo slow to load during a full page refresh: across all pages with logo
4 participants