Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Response Headers not updated after next request #359

Open
EyalC0 opened this issue Apr 19, 2023 · 2 comments
Open

Response Headers not updated after next request #359

EyalC0 opened this issue Apr 19, 2023 · 2 comments
Labels
priority-pending

Comments

@EyalC0
Copy link

EyalC0 commented Apr 19, 2023

The get_headers() function returns the same headers after calling the next function, preventing implementation of pagination rate limiter
@EyalC0
Copy link
Author

EyalC0 commented Apr 19, 2023

Suggestion
Add the line
self._resp_headers = res_details.headers
in the api_response.py after the line
self._next = next_response._next

@haggrip haggrip mentioned this issue Jul 13, 2023
Merged
@bryanapellanes-okta
Copy link
Contributor

@EyalC0 Thank you for submitting this. We will review further internally; see comment here: #364 (comment)

Internal Ref#: OKTA-641384

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority-pending
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bryanapellanes-okta @EyalC0