Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add open telemetry tracing to the SDK #431

Open
craigpastro opened this issue Feb 22, 2024 · 1 comment
Open

Add open telemetry tracing to the SDK #431

craigpastro opened this issue Feb 22, 2024 · 1 comment
Labels
enhancement New feature or request stale

Comments

@craigpastro
Copy link

Describe the feature request?

In order to get more visibility into the request lifecycle it would be nice if there were traces, at least at the top-level methods. We make a lot of requests using this SDK and currently use a TracingClientWrapper, but it would be nice if tracing were built-in.

New or Affected Resource(s)

Most, if not all, resources.

Provide a documentation link

No response

Additional Information?

Ideally, this would just involve adding a couple of lines to top-level methods. For example, add

var tracer = otel.Tracer("github.com/okta/okta-sdk-golang/okta")

to okta/okta.go and then, e.g., in okta/user.go the use of this tracer would look something like:

... stuff

func (m *UserResource) CreateUser(ctx context.Context, body CreateUserRequest, qp *query.Params) (*User, *Response, error) {
    ctx, span := tracer.Start(ctx, "CreateUser")
    defer span.End()
    ...
}

... rest of stuff

I'm happy to create a PR if you think this is something that you wish to add.

Thank you!

@craigpastro craigpastro added the enhancement New feature or request label Feb 22, 2024
Copy link

github-actions bot commented Mar 8, 2024

This issue has been marked stale because there has been no activity within the last 14 days. To keep this issue active, remove the stale label.

@github-actions github-actions bot added the stale label Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale
Projects
None yet
Development

No branches or pull requests

1 participant