Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support setting X-Forwarded-* headers #16

Closed
bdemers opened this issue Jul 20, 2018 · 7 comments
Closed

Support setting X-Forwarded-* headers #16

bdemers opened this issue Jul 20, 2018 · 7 comments
Milestone

Comments

@bdemers
Copy link
Contributor

bdemers commented Jul 20, 2018

Based on comments from #13 and #14 from @mfulgo

Setting a X-Forwarded-For header is required for this scenario.

(comments welcome)

@bdemers
Copy link
Contributor Author

bdemers commented Jul 20, 2018

@mfulgo Let's chat about this use case a little more on this issue.

How much are you tweaking the response bodies when proxying the requests? Is it a straight proxy, or are you supporting a migration scenario ?

@bdemers bdemers changed the title Support Proxy/Gateway use case (proxy /authn api) Support Proxy/Gateway use case (proxy /authn api) Jul 20, 2018
@mfulgo
Copy link

mfulgo commented Jul 20, 2018

It's not a straight proxy: I'm expecting to drop the links and some other fields from the responses, as I expect the client application to know and follow a certain flow, and I don't want to expose the Okta endpoint URL.

I also need to do some custom validation of phone numbers used for SMS factors, which is one of the primary reasons for doing the proxy.

@bdemers
Copy link
Contributor Author

bdemers commented Jul 20, 2018

Thanks! that helps!

@bdemers bdemers changed the title Support Proxy/Gateway use case (proxy /authn api) Support setting X-Forwarded-* headers Aug 22, 2018
@bdemers bdemers added Triaged and removed Analysis labels Aug 22, 2018
@jmalickenexient
Copy link

Any update here? I've looked through the docs and library and sadly it looks like I'd have to hack the inner-guts to send a X-Forwarded-* header (which is not easily feasible and comes with a host of its own problems). Appreciate your hard work on this library and any updates you have to share.

@bdemers bdemers added Analysis and removed Triaged labels Feb 25, 2019
@bdemers
Copy link
Contributor Author

bdemers commented Mar 5, 2019

Nothing yet, what are you currently doing? maybe we can provide another option?

bdemers added a commit that referenced this issue Mar 11, 2019
bdemers added a commit that referenced this issue Mar 14, 2019
@bdemers bdemers removed the Analysis label Mar 14, 2019
@mfulgo
Copy link

mfulgo commented Mar 15, 2019

Thanks, @bdemers!

@bdemers bdemers added this to the 0.4.0 milestone Mar 25, 2019
@jmalickenexient
Copy link

Thank you @bdemers !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants