Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Asciidoc as markup language #742

Open
kevintruong opened this issue Apr 20, 2020 · 3 comments
Open

Support Asciidoc as markup language #742

kevintruong opened this issue Apr 20, 2020 · 3 comments

Comments

@kevintruong
Copy link

feature

What happened: The them is not support asciidoc as native

What you expected to happen: Support asciidoc like markdown

How to reproduce it (as minimally and precisely as possible): Change to use .md file to use .adoc file

Anything else we need to know?:

Environment:

  • Syna Theme version: 0.62
  • Hugo version: 0.69
  • Others:
@stp-ip
Copy link
Member

stp-ip commented Apr 20, 2020

This might be a bigger change as we currently use the markdownify function from Hugo, which doesn't support additional content rendering engines.

Generally it feels like Hugo is primarily focussed on markdown. We might be open for a PR on this.
As far as my understanding goes we would need to move our markdownify usage to .RenderString instead. It needs to be backwards compatible so.

Ref: https://gohugo.io/functions/renderstring/

Thoughts @mpourismaiel ?

@kevintruong
Copy link
Author

Last time I checked with the theme and build my website that hugo already support to change to use asciidoc/asciidoctor to build my doc and use the theme also. But the reason I add a ticket here is the theme is not fully support asciidoc. Some kind of missing support on toc ... There are obviously different UI between Markdown and Asciidoc.
I already work on Markdown for documentation but It is really limited when compare to asciidoc. That's why I used asciidoc rather than markdown.
Can you give me some thoughts about it. I'm not a web engineer, then quite difficult to me on getting start to the new field. But I am open to the challenge .
Thanks

@stp-ip
Copy link
Member

stp-ip commented Apr 23, 2020

Could you provide more context on the specific things not working with asciidoc? As mentioned we currently use markdownify within most of our code, which doesn't support different rendering engines.
Moving to renderstring is not yet planned, but could be interesting. We'll keep it in our mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants