-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[code] Custom background code color now results in weird code blocks #672
Comments
Would you please provide more information on the issue? I'm afraid I don't understand. |
This got fixed. |
I think this might have been fixed by weird behaviour from Hugo: With code fencing disabled it doesn't show up:
It also doesn't show up, if the code block is embed in "raw" html (that's why assumed it was gone):
It does show up on bare code blocks so:
Sidenote: Had to escape the codeblocks inside the issue codeblocks ^^ |
We could either remove highlighting by default in our config or remove our own code block coloring. Not sure, if anything else makes more sense so. |
I'm not really sure what would be a better default. |
Please let me know which option you prefer and I can create a PR right away. |
As discussed remove our specific background for code snippets. The code highlighter is much more elaborate than our coloring, so removing ours in favor feels right. Not sure we could or should do add our own style, when the hugo highlighter is disabled so. |
Is this a BUG REPORT or FEATURE REQUEST?:
bug
What happened:
Currently code blocks have 2 different background color shades.
What you expected to happen:
Single background color.
How to reproduce it (as minimally and precisely as possible):
https://about.okkur.org/syna/docs/installation/#using-starter
The text was updated successfully, but these errors were encountered: