Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code] Custom background code color now results in weird code blocks #672

Open
stp-ip opened this issue Dec 19, 2019 · 7 comments
Open

[code] Custom background code color now results in weird code blocks #672

stp-ip opened this issue Dec 19, 2019 · 7 comments
Labels
Milestone

Comments

@stp-ip
Copy link
Member

stp-ip commented Dec 19, 2019

Is this a BUG REPORT or FEATURE REQUEST?:
bug

What happened:
Currently code blocks have 2 different background color shades.

What you expected to happen:
Single background color.

How to reproduce it (as minimally and precisely as possible):
https://about.okkur.org/syna/docs/installation/#using-starter

@stp-ip stp-ip added the bug label Dec 19, 2019
@stp-ip stp-ip added this to the v0.16.0 milestone Dec 19, 2019
@stp-ip stp-ip modified the milestones: v0.16.0, v0.16.1 Dec 31, 2019
@mpourismaiel
Copy link
Member

Would you please provide more information on the issue? I'm afraid I don't understand.

@stp-ip
Copy link
Member Author

stp-ip commented Jan 22, 2020

This got fixed.

@stp-ip stp-ip closed this as completed Jan 22, 2020
@stp-ip
Copy link
Member Author

stp-ip commented Apr 4, 2020

I think this might have been fixed by weird behaviour from Hugo:

With code fencing disabled it doesn't show up:

[markup]
  [markup.highlight]
    codeFences = false

It also doesn't show up, if the code block is embed in "raw" html (that's why assumed it was gone):

<details><summary>Code</summary>
/```
+++
fragment = "content"
weight = 100
+++

Hello world! This is my first blog post.
/```
</details>

It does show up on bare code blocks so:

/```
+++
fragment = "content"
weight = 100
+++

Hello world! This is my first blog post.
/```

Sidenote: Had to escape the codeblocks inside the issue codeblocks ^^

@stp-ip stp-ip reopened this Apr 4, 2020
@stp-ip stp-ip modified the milestones: v0.16.1, v0.17.0 Apr 4, 2020
@stp-ip
Copy link
Member Author

stp-ip commented Apr 4, 2020

We could either remove highlighting by default in our config or remove our own code block coloring. Not sure, if anything else makes more sense so.

@stp-ip stp-ip modified the milestones: v0.17.0, v0.18.0 Apr 29, 2020
@mpourismaiel
Copy link
Member

I'm not really sure what would be a better default.

@mpourismaiel
Copy link
Member

Please let me know which option you prefer and I can create a PR right away.

@stp-ip stp-ip modified the milestones: v0.17.1, v0.18.0 May 23, 2020
@stp-ip
Copy link
Member Author

stp-ip commented May 23, 2020

As discussed remove our specific background for code snippets. The code highlighter is much more elaborate than our coloring, so removing ours in favor feels right.
If one wants to disable the highlighter and add their own coloring, we do have custom CSS.

Not sure we could or should do add our own style, when the hugo highlighter is disabled so.

@stp-ip stp-ip modified the milestones: v0.17.3, v0.18.0 Jul 27, 2020
@stp-ip stp-ip modified the milestones: v0.17.4, v0.18.0 Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants