Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable slim build #2390

Open
taoeffect opened this issue Oct 22, 2024 · 1 comment
Open

Disable slim build #2390

taoeffect opened this issue Oct 22, 2024 · 1 comment
Assignees
Labels
App:Frontend Kind:Enhancement Improvements, new features, performance upgrades, etc. Note:Tooling

Comments

@taoeffect
Copy link
Member

Problem

Recent changes by @corrideat have made it so that the full compiled contracts and their slim versions are about the same size.

If this is indeed so, there's no reason to build or load the slim versions, as it slows down the build time.

Solution

  1. Verify the difference in size between the contracts. If it's negligible, proceed to the next step.
  2. Update the build process so that a constant is defined at the top that specifies whether or not to build and sign the slim version.
  3. Use this constant in the build process. When it's true, build and sign the slim version, when it's false, don't.
  4. Verify everything works still and the tests pass.
@taoeffect taoeffect added Kind:Enhancement Improvements, new features, performance upgrades, etc. App:Frontend Note:Tooling labels Oct 22, 2024
@snowteamer
Copy link
Collaborator

Differences in size are indeed negligible:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App:Frontend Kind:Enhancement Improvements, new features, performance upgrades, etc. Note:Tooling
Projects
None yet
Development

No branches or pull requests

2 participants