Skip to content
This repository was archived by the owner on Jun 7, 2019. It is now read-only.

"Update Chrome" dialog #24

Closed
flokol120 opened this issue Dec 16, 2018 · 26 comments
Closed

"Update Chrome" dialog #24

flokol120 opened this issue Dec 16, 2018 · 26 comments
Assignees
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@flokol120
Copy link
Collaborator

flokol120 commented Dec 16, 2018

image
Sorry for the german dialog. It says that the used chrome version is deprecated and won't be supported anymore in the near future.
Updating electron might do the trick.

see: #24 (comment)

@flokol120 flokol120 added the bug Something isn't working label Dec 16, 2018
@flokol120 flokol120 self-assigned this Dec 16, 2018
@jcrollard84
Copy link

Same issue. Just installed via git instructions.

I get the dialogue alot. Any resolution?

@flokol120
Copy link
Collaborator Author

@jcrollard84 I tried to update electron but this didn't solve the issue. With the Beta version of electron I'm getting several errors but the beta version is using a newer chromium version. As soon as I got some time I'll take a deeper look into that.

@jcrollard84
Copy link

@jcrollard84 I tried to update electron but this didn't solve the issue. With the Beta version of electron I'm getting several errors but the beta version is using a newer chromium version. As soon as I got some time I'll take a deeper look into that.

Ok, thanks :)

@flokol120
Copy link
Collaborator Author

Update: The Beta version seems the be using an outdated version as well. Maybe quitting the dialog automatically on start would be a dirty, yet easy workaround.

@blakethepatton
Copy link

If you're doing a dirty fix, you could try just modifying the user agent. Maybe throw a polyfill in to make sure the latest js features are available...

@flokol120
Copy link
Collaborator Author

flokol120 commented Dec 27, 2018

Update: @blakethepatton unfortunately, modifying the user agent in both the main.ts and the renderer.ts doesn't seem to do the trick. Maybe they are checking on new JS features which aren't implemented yet. I'll try a polyfill as soon as I got some free time.

@flokol120 flokol120 changed the title Update Chrome dialog "Update Chrome" dialog Jan 4, 2019
@flokol120
Copy link
Collaborator Author

image
Now there is also stuff going on in the console. I am not entirely sure what is going wrong. Maybe somebody who worked with AWS before can read something out of it.

@eclyptox
Copy link

Updated to electron 4 and still appearing dialog.

@flokol120
Copy link
Collaborator Author

Update: The Beta version seems the be using an outdated version as well. Maybe quitting the dialog automatically on start would be a dirty, yet easy workaround.

@eclyptox Thanks but I have tested this already. It's due to the outdated chromium version embedded into electron. I guess we have to wait until electron is updating its chromium version.

@slaybhi
Copy link

slaybhi commented Feb 9, 2019

It stopped showing the close button on the "Update Chrome" box.
It was working okay until last week. and i didn't update anything. Is it just my problem ?
deepinscreenshot_20190209223646

@mmilleror
Copy link

I just did a fresh install and received the same message.

@blakethepatton
Copy link

I'm still seeing the close button. Probably just an incremental rollout.

@latinomx
Copy link

The same issue 17 feb

@rovingrambler
Copy link

Ditto. Been getting the warning for a while, today it stopped working.

image

@blakethepatton
Copy link

There's a new version of electron out... I tried updating and building but it's my first time messing with electron and when I went to run the app I got nothing. One breaking change that I fixed locally:

main.ts:32

-const shouldQuit = app.makeSingleInstance((commandLine, workingDirectory) => {
+app.requestSingleInstanceLock()
+const shouldQuit = app.on('second-instance', (event, commandLine, workingDirectory) => {

@flokol120
Copy link
Collaborator Author

@blakethepatton I stumbled on that too. Though I did not get it working. I even tried to switch to BrowserView but that didn't work either. I found an official amazon music help page where it said specifically that Linux is not supported. Unfortunately I did not found the US version of this, only the german one. I have had the bad feeling that we are specifically blocked out by amazon 😞.

@blakethepatton
Copy link

Well my issue was that I couldn't launch the electron app after building it... But I did upgrade from 2.0.9 to 4.0.6. I'm sure that somewhere something changed that prevented me from opening my build... I've just never played with electron before today so I wasn't able to figure out why it wouldn't launch... I'm sure I have a log somewhere, just don't know where to look. I'll probably take a more through look Friday and try again.

Looks like you need to be running chrome 64+ to get their site working. I doubt it's a direct attack against your app.

@pranavt
Copy link

pranavt commented Feb 28, 2019

Blocked from running it today. Does building from the git source allow running the latest version of Electron, and consequently the latest version of the Chrome runtime?

@blakethepatton
Copy link

@pranavt I tried doing the upgrade of electron locally and building... But the app never launched for me. And I haven't worked with electron enough to know what I did wrong. So to answer your question, no.

@flokol120
Copy link
Collaborator Author

Well my issue was that I couldn't launch the electron app after building it... But I did upgrade from 2.0.9 to 4.0.6. I'm sure that somewhere something changed that prevented me from opening my build... I've just never played with electron before today so I wasn't able to figure out why it wouldn't launch... I'm sure I have a log somewhere, just don't know where to look. I'll probably take a more through look Friday and try again.

Looks like you need to be running chrome 64+ to get their site working. I doubt it's a direct attack against your app.

If running Chrome was necessary we would be knocked out. I installed the chromium version of the latest electron beta and I was able to listen to music. So Chrome is not required. Nevertheless I could not get it to work through electrons built-in chromium.

@flokol120
Copy link
Collaborator Author

Update on this matter:
I took a deeper look into amazon music and found the following:

var a = n("HUa0")
          , s = n("ImCZ")
          , o = n("LvDl")
          , l = n("pRuz")
          , c = [{
            dmlsName: "WIDEVINE",
            keySystem: "com.widevine.alpha",
            supportedConfiguration: [{
                initDataTypes: ["cenc"],
                audioCapabilities: [{
                    contentType: 'audio/mp4;codecs="mp4a.40.2"'
                }]
            }]
        }, {
            dmlsName: "PLAYREADY",
            keySystem: "com.microsoft.playready",
            supportedConfiguration: [{
                initDataTypes: ["cenc"],
                audioCapabilities: [{
                    contentType: 'audio/mp4;codecs="mp4a.40.2"'
                }]
            }]
        }]
          , u = (i(r = {}, amznMusic.constants.BROWSER_ENUMS.CHROME, c[0]),
        i(r, amznMusic.constants.BROWSER_ENUMS.FIREFOX, c[0]),
        i(r, amznMusic.constants.BROWSER_ENUMS.OPERA, c[0]),
        i(r, amznMusic.constants.BROWSER_ENUMS.BRAVE, c[0]),
        i(r, amznMusic.constants.BROWSER_ENUMS.IE, c[1]),
        i(r, amznMusic.constants.BROWSER_ENUMS.EDGE, c[1]),
        r);

The interesting part is that amazon music seems to be using playready DRM by Microsoft and most importantly Widevine by Google.
Problem with that is electron does not support Widevine on linux. See electron/#12427:

Additionally, the castLabs version will always be behind the electron version and does not support Linux.

TL;DR: I am afraid this project seems to be dead. 😞

@flokol120 flokol120 added the wontfix This will not be worked on label Apr 27, 2019
@blakethepatton
Copy link

Thanks for trying! It was a great application while it lasted.

@rovingrambler
Copy link

rovingrambler commented May 1, 2019 via email

@rovingrambler
Copy link

rovingrambler commented May 1, 2019 via email

@blakethepatton
Copy link

@rovingrambler

I think @flokol120 already looked in to the castlabs version.

Additionally, the castLabs version will always be behind the electron version and does not support Linux.

Just looked into why there isn't linux support and allegedly the linux userbase is too small for widevine.

castlabs/electron-releases#5 (comment)

They believe Linux is not currently a large enough Electron platform to warrant spending the time required to make the required additions to the CDM, so it has been put on ice for now.

@rovingrambler
Copy link

I've moved to Nuvola Apps.
Working well. Their Amazon desktop app downloads chrome and extracts widevine

https://nuvola.tiliado.eu/

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

9 participants