Port other steps and pipelines

[zonca]

@astrobc1 great job on #62, I think you can go ahead and port all other steps and pipelines.

I suggest this order:

• individual steps
• pipelines (just image2 if I'm not mistaken)
• steps/pipelines that mentions subarrays (I remember they were tricky)

Please 1 separate pull request for each test case.
If you ever get stuck, please still open a pull request with partial work and explain what is the issue.

[zonca]

you might need to adjust the calibration files on crds cache for some of these to work, in that case do a concurrent PR to https://github.com/oirlab/liger-iris-crds-cache

[astrobc1]

@zonca I ported assign_wcs on a new branch. One minor change I don't quite understand was checking for membership in a DataModel's meta attribute (previously was if attr not in meta, see Note):

liger_iris_pipeline/liger_iris_pipeline/assign_wcs/assign_wcs.py

Line 30 in 1cc4f13

if not input_model.meta.hasattr("wcsinfo"):

But the test passes and I created PR #67.

[zonca]

@astrobc1 very good,
while I review #67, please start to work on another step, make sure you start again from the main branch instead of the branch of #67, we do not want the same commits to be in 2 branches.

[zonca]

@zonca I ported assign_wcs on a new branch. One minor change I don't quite understand was checking for membership in a DataModel's meta attribute (previously was if attr not in meta, see Note):

liger_iris_pipeline/liger_iris_pipeline/assign_wcs/assign_wcs.py

Line 30 in 1cc4f13

if not input_model.meta.hasattr("wcsinfo"):

But the test passes and I created PR #67.

I guess this was a bug either in an older version of jwst or in iris_pipeline itself, it looks good now.

[zonca]

@astrobc1 I fixed the strange issue we had in Github Actions in ee3203b

so please rebase your current branches on master so you can pick up this commit and we can have the tests properly running in Github Actions

[astrobc1]

@zonca (sorry hit post early on accident!) Looking at what's next. Remaining .ipynb files are:

1. run_image2_subarray.ipynb
2. test_create_subarray_dataset.ipynb
3. test_dark_subarray.ipynb
4. test_merge_subarrays.ipynb

I think 1 is addressed by the second function in test_image2.py? #70 is 4 above. I think I can finish 2-4 by Tuesday.

[zonca]

@astrobc1 great, it would be nice to get them done by Tuesday so we can plan for what comes next.
Would you be able to do that? Otherwise I can take care of these last 2.

[zonca]

@astrobc1 there is also #70 to finalize

[astrobc1]

Sorry I don't think GitHub notifies fixed comments. I can take care of 2-4 above by Tuesday.

[zonca]

Sorry I don't think GitHub notifies fixed comments. I can take care of 2-4 above by Tuesday.

Good, I'll be on alert for review requests

[zonca]

@astrobc1 with #82 we are done, great job! liger_iris_pipeline is completely ported to the new version of jwst.
Next we can cleanup the docs and plan for the next steps.