Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Enhancment: Unify styles and theme into a dynamic and configurable config #3

Open
orpheus opened this issue Apr 8, 2019 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@orpheus
Copy link
Collaborator

orpheus commented Apr 8, 2019

Feature Enhancement

Move hardcoded style constants to a configurable MUI theme.

Create a file (either json or javascript) that allows an individual to set certain elements of the theme from outside the MUI Config (the MUI Config reads from this file). Reference Davi for which elements should be 'settable' (primary/secondary color, etc)

Current Behavior

With the current styling solution, DDX is using a mix of MUI theme variables (in the form of const style => theme> ({...}) and custom style variables (i.e those found in src/assets/jss/ddx-react.jsx).

Reasoning

To create a single source of truth (as much as possible) for the styling and theming of an app that can be dynamically configured by an outside source to spawn off variations of the app with personally-customizable elements.

@orpheus orpheus added the enhancement New feature or request label Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants